diff --git a/app/assets/stylesheets/toggles.css b/app/assets/stylesheets/toggles.css new file mode 100644 index 000000000..d37f6a21b --- /dev/null +++ b/app/assets/stylesheets/toggles.css @@ -0,0 +1,13 @@ +.toggler--toggled { + .toggler__visible-when-off { + display: none; + } + + .toggler__visible-when-on { + display: unset; + } +} + +.toggler__visible-when-on { + display: none; +} diff --git a/app/controllers/buckets_controller.rb b/app/controllers/buckets_controller.rb index a388968b5..b6cbe66dc 100644 --- a/app/controllers/buckets_controller.rb +++ b/app/controllers/buckets_controller.rb @@ -22,7 +22,7 @@ class BucketsController < ApplicationController def update @bucket.update! bucket_params - @bucket.accesses.revise(granted: grantees, revoked: revokees) unless @bucket.all_access? + @bucket.accesses.revise granted: grantees, revoked: revokees redirect_to bubbles_path(bucket_ids: [ @bucket ]) end diff --git a/app/controllers/concerns/bucket_scoped.rb b/app/controllers/concerns/bucket_scoped.rb index be9c8b99b..c0dd1176f 100644 --- a/app/controllers/concerns/bucket_scoped.rb +++ b/app/controllers/concerns/bucket_scoped.rb @@ -7,12 +7,6 @@ module BucketScoped private def set_bucket - bucket = Current.account.buckets.find params[:bucket_id] - - if bucket.visible_to? Current.user - @bucket = bucket - else - head :forbidden - end + @bucket = Current.user.buckets.find(params[:bucket_id]) end end diff --git a/app/models/bucket/accessible.rb b/app/models/bucket/accessible.rb index 63002d949..4b21c117b 100644 --- a/app/models/bucket/accessible.rb +++ b/app/models/bucket/accessible.rb @@ -15,7 +15,7 @@ module Bucket::Accessible end def revoke_from(users) - destroy_by user: users + destroy_by user: users unless proxy_association.owner.all_access? end end @@ -27,10 +27,6 @@ module Bucket::Accessible after_save_commit :grant_access_to_everyone end - def visible_to?(user) - (account == user.account && all_access?) || user.bucket_ids.include?(id) - end - private def grant_access_to_everyone accesses.grant_to(account.users) if all_access_previously_changed?(to: true) diff --git a/app/views/buckets/_user_toggle.html.erb b/app/views/buckets/_user_toggle.html.erb index 874dc2ed4..ee6c3e3a7 100644 --- a/app/views/buckets/_user_toggle.html.erb +++ b/app/views/buckets/_user_toggle.html.erb @@ -15,7 +15,9 @@ <%= hidden_field_tag "user_ids[]", user.id, id: nil %> <%= image_tag "check.svg", size: 20, class: "colorize--black flex-item-no-shrink", aria: { hidden: "true" } %> <% else %> -