From 08fb92b52637812adf6187ea27d4781f4e6eb259 Mon Sep 17 00:00:00 2001 From: Jason Zimdars Date: Wed, 12 Feb 2025 16:18:08 -0600 Subject: [PATCH] We only need to mention buckets if scoped --- app/models/filter/summarized.rb | 2 -- test/models/filter_test.rb | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/app/models/filter/summarized.rb b/app/models/filter/summarized.rb index ee0e41060..3e954e51c 100644 --- a/app/models/filter/summarized.rb +++ b/app/models/filter/summarized.rb @@ -37,8 +37,6 @@ module Filter::Summarized def bucket_summary if buckets.any? "in #{buckets.pluck(:name).to_choice_sentence}" - else - "in all collections" end end diff --git a/test/models/filter_test.rb b/test/models/filter_test.rb index 8daa7e384..9c5ef0d9a 100644 --- a/test/models/filter_test.rb +++ b/test/models/filter_test.rb @@ -103,10 +103,10 @@ class FilterTest < ActiveSupport::TestCase end test "summary" do - assert_equal "Most discussed, tagged #Mobile, and assigned to JZ in all collections", filters(:jz_assignments).summary + assert_equal "Most discussed, tagged #Mobile, and assigned to JZ ", filters(:jz_assignments).summary filters(:jz_assignments).update!(stages: workflow_stages(:qa_triage, :qa_in_progress)) - assert_equal "Most discussed, tagged #Mobile, assigned to JZ, and staged in Triage or In Progress in all collections", filters(:jz_assignments).summary + assert_equal "Most discussed, tagged #Mobile, assigned to JZ, and staged in Triage or In Progress ", filters(:jz_assignments).summary filters(:jz_assignments).update!(stages: [], assignees: [], tags: [], buckets: [ buckets(:writebook) ]) assert_equal "Most discussed in Writebook", filters(:jz_assignments).summary