From 0a58411398183302cef2ba71fb60df508d89966d Mon Sep 17 00:00:00 2001
From: Jason Zimdars <jz@37signals.com>
Date: Thu, 18 Sep 2025 11:26:01 -0500
Subject: [PATCH] Move closed to a column

---
 app/assets/stylesheets/card-columns.css       | 103 ++----------------
 app/views/cards/index/_columns.html.erb       |   6 +-
 .../cards/index/engagement/_closed.html.erb   |   8 +-
 3 files changed, 16 insertions(+), 101 deletions(-)

diff --git a/app/assets/stylesheets/card-columns.css b/app/assets/stylesheets/card-columns.css
index 6817b763c..a142d5f23 100644
--- a/app/assets/stylesheets/card-columns.css
+++ b/app/assets/stylesheets/card-columns.css
@@ -106,8 +106,12 @@
 
     .cards__expander-button {
       --btn-padding: 0;
+      --focus-ring-size: 0;
+
+      flex-grow: 1;
 
       .cards.is-collapsed & {
+        justify-content: start;
         writing-mode: vertical-rl;
       }
     }
@@ -381,15 +385,6 @@
     }
   }
 
-  /* On Deck
-  /* ------------------------------------------------------------------------ */
-
-  .cards--on-deck {
-    @media (min-width: 640px) {
-      padding-inline: var(--cards-gap);
-    }
-  }
-
   /* Doing
   /* ------------------------------------------------------------------------ */
 
@@ -399,100 +394,16 @@
     @media (min-width: 640px) {
       padding-inline: var(--cards-gap);
     }
-
-    @media (max-width: 639px) {
-      &::before {
-        background: var(--gradient-border);
-        block-size: 1px;
-        content: "";
-        inset: 0 0 auto;
-        opacity: 0.15;
-        position: absolute;
-      }
-    }
   }
 
   /* Closed
   /* ------------------------------------------------------------------------ */
 
   .cards--closed {
-    justify-content: center;
-    flex-direction: row;
-    flex-wrap: wrap;
-    inline-size: 100%;
-    margin: 0 auto;
-    position: relative;
+    margin-block: var(--cards-gap);
 
-    &:before {
-      background: var(--gradient-border);
-      block-size: 1px;
-      content: "";
-      inset: 0 -0.6em 100% -0.6em;
-      opacity: 0.15;
-      position: absolute;
-    }
-
-    @media (max-width: 639px) {
-      flex-direction: column;
-      padding-inline: var(--reserved-bubble-space);
-    }
-
-    .cards__heading {
-      min-inline-size: 100%;
-
-      @media (max-width: 639px) {
-        margin-inline-end: calc(-1 * var(--cards-gap));
-      }
-    }
-
-    .card {
-      @media (min-width: 640px) {
-        inline-size: calc((100% - var(--cards-gap)) / 2);
-      }
-
-      @media (min-width: 960px) {
-        inline-size: calc((100% - var(--cards-gap) * 2) / 3);
-      }
-
-      &:nth-of-type(7) {
-        margin-block-start: var(--cards-gap);
-      }
-
-      &:nth-of-type(n+7) {
-        background-color: var(--color-canvas);
-        border: none;
-        border-block-end: 1px solid var(--color-ink-lighter);
-        box-shadow: none;
-        inline-size: 100%;
-        margin-inline: auto;
-        max-inline-size: 110ch;
-        padding: 0 0 var(--cards-gap);
-
-        .card__meta,
-        .card__closed-by-line,
-        .card__closed-date {
-          display: none;
-        }
-
-        .card__body {
-          padding-block-end: 0;
-        }
-
-        .card__closed {
-          border-width: 0.5ch;
-          font-size: 0.75em;
-          inset: auto 0 var(--cards-gap) auto;
-          rotate: 0deg;
-        }
-
-        .card__header {
-          margin: 0;
-        }
-
-        .card__title {
-          min-block-size: 0;
-        }
-      }
+    @media (min-width: 640px) {
+      padding-inline: var(--cards-gap);
     }
   }
 }
diff --git a/app/views/cards/index/_columns.html.erb b/app/views/cards/index/_columns.html.erb
index 53ff01811..d0e81f99b 100644
--- a/app/views/cards/index/_columns.html.erb
+++ b/app/views/cards/index/_columns.html.erb
@@ -5,13 +5,13 @@
 
       <% if workflow = user_filtering.single_collection.workflow %>
         <% workflow.stages.each do |stage| %>
-          <%= render "cards/index/engagement/doing", user_filtering: user_filtering, **doing.to_h, stage: stage%>
+          <%= render "cards/index/engagement/doing", user_filtering: user_filtering, **doing.to_h, stage: stage %>
         <% end %>
       <% else %>
         <%= render "cards/index/engagement/doing", user_filtering: user_filtering, **doing.to_h %>
       <% end %>
-    </div>
 
-    <%= render "cards/index/engagement/closed", user_filtering: user_filtering, **closed.to_h %>
+      <%= render "cards/index/engagement/closed", user_filtering: user_filtering, **closed.to_h %>
+    </div>
   <% end %>
 <% end %>
diff --git a/app/views/cards/index/engagement/_closed.html.erb b/app/views/cards/index/engagement/_closed.html.erb
index ad323c67b..f73729404 100644
--- a/app/views/cards/index/engagement/_closed.html.erb
+++ b/app/views/cards/index/engagement/_closed.html.erb
@@ -1,5 +1,9 @@
-<section id="closed-cards" class="cards cards--closed pad-block">
-  <h2 class="cards__heading"><span class="cards__filter btn non-clickable borderless">Recently closed</span></h2>
+<section id="closed-cards" class="cards cards--closed pad-block is-collapsed" style="--card-color: var(--color-black);"
+    data-controller="toggle-class" data-toggle-class-toggle-class="is-collapsed">
+  <div class="cards__expander btn btn--plain">
+    <strong class="font-weight-black cards__expander-count"><%= page.records.count %></strong>
+    <button class="btn btn--plain cards__expander-button txt-uppercase" data-action="toggle-class#toggle">Done</button>
+  </div>
 
   <% if page.used? %>
     <%= render partial: "cards/display/preview", collection: page.records, as: :card, cached: true %>