bterkuile/fizzy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Port over Jeremy's fix for slow uploads

Browse Source 
ref: https://fizzy.37signals.com/5986089/collections/7/cards/944
This commit is contained in:
Mike Dalessio
2025-07-20 13:19:53 -04:00
parent af1aeca1c6
commit 0a92fc3a16
2 changed files with 47 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/lib/rails_ext/active_storage_blob_service_url_for_direct_upload_expiry_test.rb
+24
View File
@@ -0,0 +1,24 @@
require "test_helper"
class ActiveStorageBlobServiceUrlForDirectUploadExpiryTest < ActiveSupport::TestCase
setup do
@blob = ActiveStorage::Blob.new(key: "test", filename: "test.txt", byte_size: 1024, checksum: "abc")
end
test "uses extended expiry by default" do
@blob.service.expects(:url_for_direct_upload).with(@blob.key, expires_in: ActiveStorage.service_urls_for_direct_uploads_expire_in, content_type: @blob.content_type, content_length: @blob.byte_size, checksum: @blob.checksum, custom_metadata: {}).returns("https://example.com/upload")
assert_equal "https://example.com/upload", @blob.service_url_for_direct_upload
end
test "service_urls_for_direct_uploads_expire_in is configurable" do
original_expire_in = ActiveStorage.service_urls_for_direct_uploads_expire_in
ActiveStorage.service_urls_for_direct_uploads_expire_in = 96.hours
@blob.service.expects(:url_for_direct_upload).with(@blob.key, expires_in: 96.hours, content_type: @blob.content_type, content_length: @blob.byte_size, checksum: @blob.checksum, custom_metadata: {}).returns("https://example.com/upload")
assert_equal "https://example.com/upload", @blob.service_url_for_direct_upload
ensure
ActiveStorage.service_urls_for_direct_uploads_expire_in = original_expire_in
end
end