bterkuile/fizzy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix back navigation from activity page to cards (#2727)

Browse Source 
Three changes needed to support navigating back from a card to the
activity page:

- Add root_path to the prefer_referrer allowlist on the card show page
- Switch event links from HTML target="_top" to data-turbo-frame="_top"
  so Turbo handles the navigation and turbo:before-visit fires to save
  the referrer
- Normalize trailing slashes in the referrer path comparison so
  /account_id and /account_id/ both match

ref: https://app.fizzy.do/5986089/cards/2390
This commit is contained in:
Mike Dalessio
2026-03-18 22:03:36 -04:00
committed by GitHub
parent 248fc5d3e7
commit 11df9c3589
4 changed files with 29 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/javascript/controllers/turbo_navigation_controller.js
+3 -2
View File
@@ -24,8 +24,9 @@ export default class extends Controller {
referrerBackLinkTargetConnected(link) {
if (!this.#referrerUrl || !this.#referrerLabel) { return }
const allowedPaths = (link.dataset.turboNavigationAllowedReferrerPaths || "").split(",")
const referrerPath = new URL(this.#referrerUrl).pathname
const stripTrailingSlash = path => path.replace(/\/$/, "")
const allowedPaths = (link.dataset.turboNavigationAllowedReferrerPaths || "").split(",").map(stripTrailingSlash)
const referrerPath = stripTrailingSlash(new URL(this.#referrerUrl).pathname)
if (!allowedPaths.includes(referrerPath)) { return }
link.href = this.#referrerUrl