bterkuile/fizzy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #2829 from basecamp/remove-tag-attachable

Browse Source 
Remove dead Tag::Attachable code and tags prompt
This commit is contained in:
Stanko Krtalić
2026-04-10 09:05:48 +02:00
committed by GitHub
parent f3f9aec547 975b8998ef
commit 127156e23a
9 changed files with 8 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/controllers/prompts/tags_controller_test.rb
-12
View File
@@ -1,12 +0,0 @@
require "test_helper"
class Prompts::TagsControllerTest < ActionDispatch::IntegrationTest
setup do
sign_in_as :kevin
end
test "index" do
get prompts_tags_path
assert_response :success
end
end
test/models/account/data_transfer/action_text/rich_text_record_set_test.rb
+7 -7
View File
@@ -44,11 +44,11 @@ class Account::DataTransfer::ActionText::RichTextRecordSetTest < ActiveSupport::
end
test "transform_body_for_import skips GIDs belonging to another account" do
victim_tag = tags(:web)
victim_user = users(:david)
attacker_account = accounts(:initech)
assert_not_equal attacker_account.id, victim_tag.account_id
assert_not_equal attacker_account.id, victim_user.account_id
cross_tenant_gid = victim_tag.to_global_id.to_s
cross_tenant_gid = victim_user.to_global_id.to_s
html = %(<action-text-attachment gid="#{cross_tenant_gid}"></action-text-attachment>)
record_set = Account::DataTransfer::ActionText::RichTextRecordSet.new(attacker_account)
@@ -59,11 +59,11 @@ class Account::DataTransfer::ActionText::RichTextRecordSetTest < ActiveSupport::
end
test "transform_body_for_import converts GIDs belonging to the same account" do
own_tag = tags(:web)
own_user = users(:david)
own_account = accounts(:"37s")
assert_equal own_account.id, own_tag.account_id
assert_equal own_account.id, own_user.account_id
same_account_gid = own_tag.to_global_id.to_s
same_account_gid = own_user.to_global_id.to_s
html = %(<action-text-attachment gid="#{same_account_gid}"></action-text-attachment>)
record_set = Account::DataTransfer::ActionText::RichTextRecordSet.new(own_account)
@@ -74,7 +74,7 @@ class Account::DataTransfer::ActionText::RichTextRecordSetTest < ActiveSupport::
end
test "transform_body_for_import handles non-existent record GIDs gracefully" do
nonexistent_gid = "gid://fizzy/Tag/00000000000000000000000000"
nonexistent_gid = "gid://fizzy/User/00000000000000000000000000"
html = %(<action-text-attachment gid="#{nonexistent_gid}"></action-text-attachment>)
record_set = Account::DataTransfer::ActionText::RichTextRecordSet.new(accounts(:"37s"))