From 139fa7afdc961f02b384aa41c5fa7222df2c5495 Mon Sep 17 00:00:00 2001 From: David Heinemeier Hansson Date: Sat, 19 Oct 2024 19:51:25 -0700 Subject: [PATCH] No need for this to be in a transaction If you update the name by itself, it is fine. We generally want to be very careful about having txn spans, since all the work done within them will block the sqlite writer. --- app/controllers/buckets_controller.rb | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/app/controllers/buckets_controller.rb b/app/controllers/buckets_controller.rb index 229e5a58c..c12843fb1 100644 --- a/app/controllers/buckets_controller.rb +++ b/app/controllers/buckets_controller.rb @@ -20,10 +20,8 @@ class BucketsController < ApplicationController end def update - @bucket.transaction do - @bucket.update! bucket_params - @bucket.accesses.revise granted: grantees, revoked: revokees - end + @bucket.update! bucket_params + @bucket.accesses.revise granted: grantees, revoked: revokees redirect_to bucket_bubbles_path(@bucket) end