bterkuile/fizzy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert CORS fetch mode for Active Storage

Browse Source 
CORS mode doesn't work with redirect-based Active Storage URLs
when the storage bucket uses wildcard Access-Control-Allow-Origin.
Relying on maxEntries alone until specific origin CORS is available.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Rosa Gutierrez
2026-02-21 09:20:47 +01:00
parent 67d629f722
commit 1855490f80
3 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Gemfile.lock
+1 -1
View File
@@ -13,7 +13,7 @@ GIT
GIT GIT
remote: https://github.com/hotwired/turbo-rails.git remote: https://github.com/hotwired/turbo-rails.git
revision: 43bc205155b0eb57e5e016ed0e87a12c29ba2ab2 revision: 93ce5bc461cd71af1797e79fcd7e09a19242d080
branch: offline-cache branch: offline-cache
specs: specs:
turbo-rails (2.0.23) turbo-rails (2.0.23)
Gemfile.saas.lock
+1 -1
View File
@@ -62,7 +62,7 @@ GIT
GIT GIT
remote: https://github.com/hotwired/turbo-rails.git remote: https://github.com/hotwired/turbo-rails.git
revision: 43bc205155b0eb57e5e016ed0e87a12c29ba2ab2 revision: 93ce5bc461cd71af1797e79fcd7e09a19242d080
branch: offline-cache branch: offline-cache
specs: specs:
turbo-rails (2.0.23) turbo-rails (2.0.23)
app/views/pwa/service_worker.js.erb
+1 -2
View File
@@ -42,8 +42,7 @@ TurboOffline.addRule({
maxAge: 60 * 60 * 24 * 7, maxAge: 60 * 60 * 24 * 7,
networkTimeout: 2, networkTimeout: 2,
maxEntrySize: 2 * 1024 * 1024, // 2MB covers about 95% of all Fizzy blobs maxEntrySize: 2 * 1024 * 1024, // 2MB covers about 95% of all Fizzy blobs
maxEntries: 500, maxEntries: 500
fetchOptions: { mode: "cors", credentials: "omit" }
}) })
}) })