Cleanup bridge components

app/javascript/controllers/bridge/buttons_controller.js

@@ -7,13 +7,18 @@ export default class extends BridgeComponent {
 
   connect() {
     super.connect()
-    if (!this.hasButtonTarget) return
-    this.notifyBridgeOfConnect()
+
+    if (this.hasButtonTarget) {
+      this.notifyBridgeOfConnect()
+    }
   }
 
   disconnect() {
     super.disconnect()
-    this.notifyBridgeOfDisconnect()
+
+    if (this.hasButtonTarget) {
+      this.notifyBridgeOfDisconnect()
+    }
   }
 
   notifyBridgeOfConnect() {
@@ -23,7 +28,7 @@ export default class extends BridgeComponent {
     })
 
     this.send("connect", { buttons }, message => {
-      this.activateButton(message)
+      this.clickButton(message)
     })
   }
 
@@ -31,7 +36,7 @@ export default class extends BridgeComponent {
     this.send("disconnect")
   }
 
-  activateButton(message) {
+  clickButton(message) {
     const selectedIndex = message.data.selectedIndex
     this.buttonTargets[selectedIndex].click()
   }

app/javascript/controllers/bridge/form_controller.js

@@ -8,9 +8,11 @@ export default class extends BridgeComponent {
 
   connect() {
     super.connect()
-    if (!this.hasSubmitTarget) return
-    this.notifyBridgeOfConnect()
-    this.observeSubmitTarget()
+
+    if (this.hasSubmitTarget) {
+      this.notifyBridgeOfConnect()
+      this.observeSubmitTarget()
+    }
   }
 
   disconnect() {

app/javascript/controllers/bridge/overflow_menu_controller.js

@@ -7,13 +7,18 @@ export default class extends BridgeComponent {
 
   connect() {
     super.connect()
-    if (!this.hasItemTarget) return
-    this.notifyBridgeOfConnect()
+
+    if (this.hasItemTarget) {
+      this.notifyBridgeOfConnect()
+    }
   }
 
   disconnect() {
     super.disconnect()
-    this.notifyBridgeOfDisconnect()
+
+    if (this.hasItemTarget) {
+      this.notifyBridgeOfDisconnect()
+    }
   }
 
   notifyBridgeOfConnect() {
@@ -23,7 +28,7 @@ export default class extends BridgeComponent {
     })
 
     this.send("connect", { items }, message => {
-      this.activateItem(message)
+      this.clickItem(message)
     })
   }
 
@@ -31,7 +36,7 @@ export default class extends BridgeComponent {
     this.send("disconnect")
   }
 
-  activateItem(message) {
+  clickItem(message) {
     const selectedIndex = message.data.selectedIndex
     this.itemTargets[selectedIndex].click()
   }