From 43d12b27edb79440a80ac703a5a5fe3b636ee454 Mon Sep 17 00:00:00 2001 From: Adrien Maston Date: Tue, 3 Feb 2026 12:12:20 +0100 Subject: [PATCH 1/2] Expand maybe column is no expanded column is found in localStorage ... to trigger scrolling into view --- app/javascript/controllers/collapsible_columns_controller.js | 1 + 1 file changed, 1 insertion(+) diff --git a/app/javascript/controllers/collapsible_columns_controller.js b/app/javascript/controllers/collapsible_columns_controller.js index e432a054f..835f05d9e 100644 --- a/app/javascript/controllers/collapsible_columns_controller.js +++ b/app/javascript/controllers/collapsible_columns_controller.js @@ -181,6 +181,7 @@ export default class extends Controller { this.#collapseAllExcept(expandedColumn) } else { this.#collapseAllExcept(this.maybeColumnTarget) + this.#expand(this.maybeColumnTarget, false) } } From aa3103de3c1a540ffe48b59c439302cf7ba98769 Mon Sep 17 00:00:00 2001 From: Adrien Maston Date: Tue, 3 Feb 2026 12:52:54 +0100 Subject: [PATCH 2/2] Rename handleDesktop method --- .../controllers/collapsible_columns_controller.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/javascript/controllers/collapsible_columns_controller.js b/app/javascript/controllers/collapsible_columns_controller.js index 835f05d9e..939fe8441 100644 --- a/app/javascript/controllers/collapsible_columns_controller.js +++ b/app/javascript/controllers/collapsible_columns_controller.js @@ -15,8 +15,8 @@ export default class extends Controller { async connect() { this.mediaQuery = window.matchMedia(this.desktopBreakpointValue) - this.handleDesktop = this.#handleDesktop.bind(this) - this.mediaQuery.addEventListener("change", this.handleDesktop) + this.handlePlatform = this.#handlePlatform.bind(this) + this.mediaQuery.addEventListener("change", this.handlePlatform) await this.#restoreColumnsDisablingTransitions() this.#setupIntersectionObserver() @@ -27,7 +27,7 @@ export default class extends Controller { this._intersectionObserver.disconnect() this._intersectionObserver = null } - this.mediaQuery.removeEventListener("change", this.handleDesktop) + this.mediaQuery.removeEventListener("change", this.handlePlatform) } toggle({ target }) { @@ -56,7 +56,7 @@ export default class extends Controller { async #restoreColumnsDisablingTransitions() { this.#disableTransitions() this.#restoreColumns() - this.#handleDesktop() + this.#handlePlatform() await nextFrame() this.#enableTransitions() @@ -163,7 +163,7 @@ export default class extends Controller { return this.mediaQuery?.matches } - #handleDesktop() { + #handlePlatform() { this.#isDesktop ? this.#handleDesktopMode() : this.#handleMobileMode() }