From 21211cedcaff9f4d6a67da241d1bf1fac1530c42 Mon Sep 17 00:00:00 2001 From: David Heinemeier Hansson Date: Sun, 6 Apr 2025 18:16:47 +0200 Subject: [PATCH] These really are anemic too --- app/models/bubble/taggable.rb | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/app/models/bubble/taggable.rb b/app/models/bubble/taggable.rb index 55b70c076..72b362976 100644 --- a/app/models/bubble/taggable.rb +++ b/app/models/bubble/taggable.rb @@ -10,19 +10,10 @@ module Bubble::Taggable def toggle_tag_with(title) tag = bucket.account.tags.find_or_create_by!(title: title) - transaction { tagged_with?(tag) ? untagging(tag) : tagging(tag) } + transaction { tagged_with?(tag) ? taggings.destroy_by(tag:) : taggings.create(tag:) } end def tagged_with?(tag) tags.include? tag end - - private - def tagging(tag) - taggings.create tag: tag - end - - def untagging(tag) - taggings.destroy_by tag: tag - end end