From 2652e210557e28d6415e03c477bbd9a75100faaa Mon Sep 17 00:00:00 2001 From: Jorge Manrubia Date: Thu, 24 Apr 2025 16:41:40 +0200 Subject: [PATCH] Remove noisy filter actions --- app/controllers/concerns/day_timelines_scoped.rb | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/app/controllers/concerns/day_timelines_scoped.rb b/app/controllers/concerns/day_timelines_scoped.rb index d98f6f617..c09c9c36a 100644 --- a/app/controllers/concerns/day_timelines_scoped.rb +++ b/app/controllers/concerns/day_timelines_scoped.rb @@ -4,26 +4,22 @@ module DayTimelinesScoped included do include FilterScoped - before_action :clear_collections_filter, if: :clear_collections_filter? - before_action :restore_collections_filter - before_action :set_day_timeline - + before_action :restore_collections_filter, :set_day_timeline after_action :save_collections_filter end private - def clear_collections_filter - cookies.delete(:collection_filter) + def restore_collections_filter + clear_collections_filter if clear_collections_filter? + @filter.collection_ids = cookies[:collection_filter].split(",") if cookies[:collection_filter].present? end def clear_collections_filter? params[:clear_filter] end - def restore_collections_filter - if cookies[:collection_filter].present? - @filter.collection_ids = cookies[:collection_filter].split(",") - end + def clear_collections_filter + cookies.delete(:collection_filter) end def set_day_timeline