From 2c79ca09d7b65f95690d11f4b91c72b07d75a2da Mon Sep 17 00:00:00 2001
From: Jason Zimdars <jz@37signals.com>
Date: Wed, 9 Apr 2025 14:40:53 -0500
Subject: [PATCH] The button and dialog need not render in previews

---
 app/views/cards/assignments/new.html.erb      | 30 +++++++++++--------
 .../cards/display/common/_assignees.html.erb  |  9 +-----
 .../cards/display/mini/_assignees.html.erb    |  7 -----
 3 files changed, 19 insertions(+), 27 deletions(-)

diff --git a/app/views/cards/assignments/new.html.erb b/app/views/cards/assignments/new.html.erb
index 7c8f2109b..e6507a80f 100644
--- a/app/views/cards/assignments/new.html.erb
+++ b/app/views/cards/assignments/new.html.erb
@@ -1,14 +1,20 @@
 <%= turbo_frame_tag @card, :assignment do %>
-  <dialog class="popup panel flex-column align-start gap-half fill-white shadow" data-dialog-target="dialog">
-    <strong class="popup__title margin-block-start-half pad-inline-half txt-nowrap">Assign this to…</strong>
+  <div class="position-relative" data-controller="dialog" data-action="keydown.esc->dialog#close click@document->dialog#closeOnClickOutside">
+    <button class="btn <%= @card.creating? || @card.drafted? ? "fill-highlight" : "fill-transparent" %>" data-action="click->dialog#open:stop">
+      <%= icon_tag "add" %>
+      <span class="for-screen-reader">Assign</span>
+    </button>
+    <dialog class="popup panel flex-column align-start gap-half fill-white shadow" data-dialog-target="dialog">
+      <strong class="popup__title margin-block-start-half pad-inline-half txt-nowrap">Assign this to…</strong>
 
-    <div class="flex flex-column full-width popup__list">
-      <% @card.collection.users.active.alphabetically.each do |user| %>
-          <%= button_to card_assignments_path(@card, params: { assignee_id: user.id }), method: :post, class: "btn popup__item full-width" do %>
-            <span class="overflow-ellipsis"><%= user.name %></span>
-            <%= icon_tag "check", size: 18, class: "checked flex-item-justify-end" if @card.assignees.include?(user) %>
-          <% end %>
-      <% end %>
-    </div>
-  </dialog>
-<% end %>
+      <div class="flex flex-column full-width popup__list">
+        <% @card.collection.users.active.alphabetically.each do |user| %>
+            <%= button_to card_assignments_path(@card, params: { assignee_id: user.id }), method: :post, class: "btn popup__item full-width" do %>
+              <span class="overflow-ellipsis"><%= user.name %></span>
+              <%= icon_tag "check", size: 18, class: "checked flex-item-justify-end" if @card.assignees.include?(user) %>
+            <% end %>
+        <% end %>
+      </div>
+    </dialog>
+  </div>
+<% end %>
\ No newline at end of file
diff --git a/app/views/cards/display/common/_assignees.html.erb b/app/views/cards/display/common/_assignees.html.erb
index 78d9e605b..fc9ebeb84 100644
--- a/app/views/cards/display/common/_assignees.html.erb
+++ b/app/views/cards/display/common/_assignees.html.erb
@@ -3,12 +3,5 @@
     <%= avatar_tag assignee, class: "avatar" %>
   <% end %>
 
-  <div class="position-relative" data-controller="dialog" data-action="keydown.esc->dialog#close click@document->dialog#closeOnClickOutside">
-    <button class="btn card__hide-on-index <%= card.creating? || card.drafted? ? "fill-highlight" : "fill-transparent" %>" data-action="click->dialog#open:stop">
-      <%= icon_tag "add" %>
-      <span class="for-screen-reader">Assign</span>
-    </button>
-
-    <%= yield %>
-  </div>
+  <%= yield %>
 </div>
diff --git a/app/views/cards/display/mini/_assignees.html.erb b/app/views/cards/display/mini/_assignees.html.erb
index e007f4bc7..a3aabbbe8 100644
--- a/app/views/cards/display/mini/_assignees.html.erb
+++ b/app/views/cards/display/mini/_assignees.html.erb
@@ -3,12 +3,5 @@
     <% card.assignees.each do |assignee| %>
       <%= avatar_tag assignee, class: "avatar" %>
     <% end %>
-
-    <div class="position-relative" data-controller="dialog" data-action="keydown.esc->dialog#close click@document->dialog#closeOnClickOutside">
-      <button class="btn card__hide-on-index <%= card.creating? || card.drafted? ? "fill-highlight" : "fill-transparent" %>" data-action="click->dialog#open:stop">
-        <%= icon_tag "add" %>
-        <span class="for-screen-reader">Assign</span>
-      </button>
-    </div>
   </div>
 <% end %>