From 2e60fcdf987f63a626a438cb1e93664282cdd338 Mon Sep 17 00:00:00 2001 From: Jorge Manrubia Date: Thu, 5 Jun 2025 16:11:48 +0200 Subject: [PATCH] Dynamic bubble timers --- app/helpers/entropy_helper.rb | 4 ++-- app/models/card/entropic.rb | 2 -- app/models/card/entropy.rb | 4 ++++ 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/app/helpers/entropy_helper.rb b/app/helpers/entropy_helper.rb index 5d1852fa4..2d7ed1c25 100644 --- a/app/helpers/entropy_helper.rb +++ b/app/helpers/entropy_helper.rb @@ -5,7 +5,7 @@ module EntropyHelper def entropy_bubble_options_for(card) { - daysBeforeReminder: Card::Entropic::ENTROPY_REMINDER_BEFORE.in_days.to_i, + daysBeforeReminder: card.entropy.days_before_reminder, closesAt: card.entropy.auto_clean_at.iso8601, action: card_entropy_action(card) } @@ -14,7 +14,7 @@ module EntropyHelper def stalled_bubble_options_for(card) if card.last_activity_spike_at { - stalledAfterDays: Card::Stallable::STALLED_AFTER_LAST_SPIKE_PERIOD.in_days.to_i, + stalledAfterDays: card.entropy.days_before_reminder, lastActivitySpikeAt: card.last_activity_spike_at.iso8601 } end diff --git a/app/models/card/entropic.rb b/app/models/card/entropic.rb index 56066491a..d275d6d81 100644 --- a/app/models/card/entropic.rb +++ b/app/models/card/entropic.rb @@ -1,8 +1,6 @@ module Card::Entropic extend ActiveSupport::Concern - ENTROPY_REMINDER_BEFORE = 7.days - included do scope :entropic_by, ->(period_name) do left_outer_joins(collection: :entropy_configuration) diff --git a/app/models/card/entropy.rb b/app/models/card/entropy.rb index c2cc45e10..5f21dd63f 100644 --- a/app/models/card/entropy.rb +++ b/app/models/card/entropy.rb @@ -21,4 +21,8 @@ class Card::Entropy def auto_clean_at card.last_active_at + auto_clean_period end + + def days_before_reminder + (auto_clean_period * 0.25).round + end end