From 2f7c3d0fd398dc70868f8f0687c6b96eced3e754 Mon Sep 17 00:00:00 2001 From: Jose Farias Date: Fri, 13 Dec 2024 14:41:10 -0600 Subject: [PATCH] Punt on removing filters for inaccessible buckets Current behavior just stops querying for bubbles in inaccessible buckets. That might be fine. --- test/models/filter_test.rb | 4 ---- 1 file changed, 4 deletions(-) diff --git a/test/models/filter_test.rb b/test/models/filter_test.rb index 4f40d4cfb..6d871326c 100644 --- a/test/models/filter_test.rb +++ b/test/models/filter_test.rb @@ -48,10 +48,6 @@ class FilterTest < ActiveSupport::TestCase assert_empty users(:david).filters.new(bucket_ids: [ buckets(:writebook).id ]).bubbles end - test "saved bucket filters are destroyed after losing access" do - skip "figuring out if this is the behavior we want" - end - test "turning into params" do expected = { indexed_by: "most_discussed", tag_ids: [ tags(:mobile).id ], assignee_ids: [ users(:jz).id ], filter_id: filters(:jz_assignments).id } assert_equal expected.stringify_keys, filters(:jz_assignments).to_params.to_h