From 2f88908cdfd0e6f3a4ecf2c01fbc3c610f97e3b8 Mon Sep 17 00:00:00 2001
From: Marco Roth <marco.roth@intergga.ch>
Date: Tue, 2 Dec 2025 17:21:35 +0100
Subject: [PATCH] Address HTML markup issues reported by Herb

---
 app/views/boards/new.html.erb                    | 2 +-
 app/views/cards/display/_public_preview.html.erb | 2 +-
 app/views/layouts/public.html.erb                | 1 +
 app/views/webhooks/show.html.erb                 | 6 +++---
 4 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/app/views/boards/new.html.erb b/app/views/boards/new.html.erb
index 57c809b17..4536af7fc 100644
--- a/app/views/boards/new.html.erb
+++ b/app/views/boards/new.html.erb
@@ -2,7 +2,7 @@
 
 <div class="panel panel--centered">
   <%= form_with model: @board, class: "flex flex-column gap", data: { controller: "form" } do |form| %>
-    <h1 class="txt-x-large margin-none font-weight-black"><%= @page_title %></h2>
+    <h1 class="txt-x-large margin-none font-weight-black"><%= @page_title %></h1>
     <%= form.text_field :name, required: true, class: "input full-width", autofocus: true, autocomplete: "off",placeholder: "Name it…", data: { action: "keydown.esc@document->form#cancel" } %>
 
     <button type="submit" class="btn btn--link center">
diff --git a/app/views/cards/display/_public_preview.html.erb b/app/views/cards/display/_public_preview.html.erb
index edf73d3de..31b511a44 100644
--- a/app/views/cards/display/_public_preview.html.erb
+++ b/app/views/cards/display/_public_preview.html.erb
@@ -37,6 +37,6 @@
 
   <% if card.entropic? %>
     <%= render "cards/display/preview/bubble", card: card %>
-      <span class="card__board-name">
+    <span class="card__board-name"></span>
   <% end %>
 <% end %>
diff --git a/app/views/layouts/public.html.erb b/app/views/layouts/public.html.erb
index 6fa51136f..6072ad16d 100644
--- a/app/views/layouts/public.html.erb
+++ b/app/views/layouts/public.html.erb
@@ -21,5 +21,6 @@
 
     <footer id="footer">
       <%= yield :footer %>
+    </footer>
   </body>
 </html>
diff --git a/app/views/webhooks/show.html.erb b/app/views/webhooks/show.html.erb
index 598cbb532..a98a8acf3 100644
--- a/app/views/webhooks/show.html.erb
+++ b/app/views/webhooks/show.html.erb
@@ -12,7 +12,7 @@
       <%= icon_tag "pencil" %>
       <span class="for-screen-reader">Edit</span>
     <% end %>
-  <div>
+  </div>
 <% end %>
 
 <div class="panel panel--wide shadow center flex flex-column gap txt-align-start">
@@ -39,7 +39,7 @@
     <div class="flex flex-column">
       <h2 class="margin-none txt-uppercase txt-medium">Subscribed to</h2>
       <% if @webhook.subscribed_actions.empty? %>
-        <p class="margin-none txt-subtle">This Webhook isn't subscribed to any events. It will never trigger.<p/>
+        <p class="margin-none txt-subtle">This Webhook isn't subscribed to any events. It will never trigger.</p>
       <% else %>
         <ul class="margin-none unpad-block">
           <% @webhook.subscribed_actions.each do |action| %>
@@ -52,7 +52,7 @@
     <div class="flex flex-column">
       <h2 class="margin-none txt-uppercase txt-medium">Deliveries</h2>
       <% if @webhook.deliveries.empty? %>
-        <p class="margin-none txt-subtle">This Webhook hasn't been triggered yet<p/>
+        <p class="margin-none txt-subtle">This Webhook hasn't been triggered yet</p>
       <% else %>
         <ul class="margin-none unpad-block">
           <%= render partial: "webhooks/delivery", collection: @webhook.deliveries.ordered.limit(20), as: :delivery %>