Consolidate push jobs into single Notification::PushJob

Replace separate WebPushJob and NativePushJob with a single PushJob
that calls notification.push, which iterates over registered targets.
Each target handles its own delivery - Web pushes synchronously via
the pool, Native enqueues device-level jobs via deliver_later_to.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Rosa Gutierrez
2026-01-22 17:19:21 +01:00
parent 4f19c42958
commit 3621df8f0f
9 changed files with 24 additions and 34 deletions
@@ -1,5 +0,0 @@
class Notification::NativePushJob < ApplicationJob
def perform(notification)
Notification::PushTarget::Native.new(notification).push
end
end
@@ -1,8 +1,4 @@
class Notification::PushTarget::Native < Notification::PushTarget
def self.push_later(notification)
Notification::NativePushJob.perform_later(notification)
end
private
def should_push?
super && devices.any?
@@ -199,9 +199,4 @@ class Notification::PushTarget::NativeTest < ActiveSupport::TestCase
assert_equal @notification.creator.name, native.data[:creator_name]
end
test "push_later enqueues Notification::NativePushJob" do
assert_enqueued_with(job: Notification::NativePushJob, args: [ @notification ]) do
Notification::PushTarget::Native.push_later(@notification)
end
end
end