From 3e7cd204db8bce832aef8ee85b38f1147014bb62 Mon Sep 17 00:00:00 2001 From: Andy Smith Date: Wed, 5 Nov 2025 11:14:30 -0600 Subject: [PATCH] Add title to Maybe column --- .../collapsible_columns_controller.js | 4 +-- app/views/collections/show/_columns.html.erb | 32 ++++++++----------- .../public/collections/show/_stream.html.erb | 2 +- 3 files changed, 17 insertions(+), 21 deletions(-) diff --git a/app/javascript/controllers/collapsible_columns_controller.js b/app/javascript/controllers/collapsible_columns_controller.js index 3d9c8f412..2b6c24e71 100644 --- a/app/javascript/controllers/collapsible_columns_controller.js +++ b/app/javascript/controllers/collapsible_columns_controller.js @@ -122,8 +122,8 @@ export default class extends Controller { this._intersectionObserver = new IntersectionObserver(entries => { entries.forEach(entry => { const title = entry.target - const column = title.closest('[data-collapsible-columns-target="column"]') - + const column = title.closest(".cards") + if (!column) return const offscreen = entry.intersectionRatio === 0 diff --git a/app/views/collections/show/_columns.html.erb b/app/views/collections/show/_columns.html.erb index a52a308dd..79a1cf4ec 100644 --- a/app/views/collections/show/_columns.html.erb +++ b/app/views/collections/show/_columns.html.erb @@ -1,32 +1,28 @@ -<%= tag.div data: { - controller: "drag-and-drop drag-and-strum", +<%= tag.div class: "card-columns", data: { + controller: "drag-and-drop drag-and-strum collapsible-columns", drag_and_drop_dragged_item_class: "drag-and-drop__dragged-item", drag_and_drop_hover_container_class: "drag-and-drop__hover-container", + collapsible_columns_collection_value: collection.id, + collapsible_columns_collapsed_class: "is-collapsed", + collapsible_columns_title_not_visible_class: "is-off-screen", + collapsible_columns_no_transitions_class: "no-transitions", action: " dragstart->drag-and-drop#dragStart dragover->drag-and-drop#dragOver dragenter->drag-and-strum#dragEnter drop->drag-and-drop#drop dragend->drag-and-drop#dragEnd" } do %> -
-
- <%= render "collections/show/not_now", collection: collection %> -
+
+ <%= render "collections/show/not_now", collection: collection %> +
- <%= render "collections/show/stream", collection: collection, page: page %> + <%= render "collections/show/stream", collection: collection, page: page %> -
- <%= render partial: "collections/show/column", collection: collection.columns.sorted, cached: ->(column){ [ column, column.leftmost?, column.rightmost? ] } %> - <%= render "collections/show/closed", collection: collection %> +
+ <%= render partial: "collections/show/column", collection: collection.columns.sorted, cached: ->(column){ [ column, column.leftmost?, column.rightmost? ] } %> + <%= render "collections/show/closed", collection: collection %> - <%= render "collections/show/menu/columns", collection: collection %> -
+ <%= render "collections/show/menu/columns", collection: collection %>
<% end %> diff --git a/app/views/public/collections/show/_stream.html.erb b/app/views/public/collections/show/_stream.html.erb index 4fc065e78..94df5f07d 100644 --- a/app/views/public/collections/show/_stream.html.erb +++ b/app/views/public/collections/show/_stream.html.erb @@ -1,4 +1,4 @@ -

Maybe?