From 3ea7da26abfdb2eceb3dcbb60bfd3bcb994c4121 Mon Sep 17 00:00:00 2001 From: Kevin McConnell Date: Thu, 27 Mar 2025 12:22:55 +0000 Subject: [PATCH] "Stalled" not "Stale" The latter sounds like old bread. --- app/models/bubble.rb | 2 +- app/models/filter/fields.rb | 2 +- test/models/filter_test.rb | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/models/bubble.rb b/app/models/bubble.rb index 5c408211d..441071f5a 100644 --- a/app/models/bubble.rb +++ b/app/models/bubble.rb @@ -20,11 +20,11 @@ class Bubble < ApplicationRecord scope :indexed_by, ->(index) do case index when "most_active" then ordered_by_activity - when "most_stale" then ordered_by_staleness when "most_discussed" then ordered_by_comments when "most_boosted" then ordered_by_boosts when "newest" then reverse_chronologically when "oldest" then chronologically + when "stalled" then ordered_by_staleness when "popped" then popped end end diff --git a/app/models/filter/fields.rb b/app/models/filter/fields.rb index 680058043..36e60ba63 100644 --- a/app/models/filter/fields.rb +++ b/app/models/filter/fields.rb @@ -1,7 +1,7 @@ module Filter::Fields extend ActiveSupport::Concern - INDEXES = %w[ most_discussed most_boosted most_stale newest oldest popped ] + INDEXES = %w[ most_discussed most_boosted newest oldest stalled popped ] delegate :default_value?, to: :class diff --git a/test/models/filter_test.rb b/test/models/filter_test.rb index 24dcab200..20740f6fd 100644 --- a/test/models/filter_test.rb +++ b/test/models/filter_test.rb @@ -111,8 +111,8 @@ class FilterTest < ActiveSupport::TestCase filters(:jz_assignments).update!(stages: [], assignees: [], tags: [], buckets: [ buckets(:writebook) ]) assert_equal "Most discussed in Writebook", filters(:jz_assignments).summary - filters(:jz_assignments).update!(indexed_by: "most_stale") - assert_equal "Most stale in Writebook", filters(:jz_assignments).summary + filters(:jz_assignments).update!(indexed_by: "stalled") + assert_equal "Stalled in Writebook", filters(:jz_assignments).summary end test "params without a key-value pair" do