From 402fe6ca39259c96c16af29dc2fc3bf509383828 Mon Sep 17 00:00:00 2001 From: Jorge Manrubia Date: Sun, 28 Sep 2025 22:04:06 +0200 Subject: [PATCH] No default columns for new collections https://3.basecamp.com/2914079/buckets/37331921/todos/9104429380#__recording_9118363137 --- app/models/collection/triageable.rb | 12 ------------ test/models/collection/triageable_test.rb | 17 ----------------- 2 files changed, 29 deletions(-) delete mode 100644 test/models/collection/triageable_test.rb diff --git a/app/models/collection/triageable.rb b/app/models/collection/triageable.rb index 6da4574dd..a314868c8 100644 --- a/app/models/collection/triageable.rb +++ b/app/models/collection/triageable.rb @@ -1,19 +1,7 @@ module Collection::Triageable extend ActiveSupport::Concern - DEFAULT_COLUMNS = [ - { name: "Figuring it out", color: "var(--color-card-5)" }, - { name: "In progress", color: "var(--color-card-3)" } - ] - included do has_many :columns, dependent: :destroy - - after_create_commit :create_default_columns end - - private - def create_default_columns - Column.insert_all(DEFAULT_COLUMNS.map { { name: it[:name], color: it[:color], collection_id: id } }) - end end diff --git a/test/models/collection/triageable_test.rb b/test/models/collection/triageable_test.rb deleted file mode 100644 index d778591e3..000000000 --- a/test/models/collection/triageable_test.rb +++ /dev/null @@ -1,17 +0,0 @@ -require "test_helper" - -class Collection::TriageableTest < ActiveSupport::TestCase - test "creating collection creates default columns" do - assert_difference -> { Column.count }, Collection::Triageable::DEFAULT_COLUMNS.size do - collection = Collection.create! name: "Test Collection", creator: users(:david) - - assert_equal Collection::Triageable::DEFAULT_COLUMNS.size, collection.columns.count - - Collection::Triageable::DEFAULT_COLUMNS.each_with_index do |default_column, index| - column = collection.columns.order(:id)[index] - assert_equal default_column[:name], column.name - assert_equal default_column[:color], column.color - end - end - end -end