From 41ab8e4ced0072f1f48e55d908cdab0df5ab2f66 Mon Sep 17 00:00:00 2001
From: Jorge Manrubia <jorge@hey.com>
Date: Thu, 16 Oct 2025 14:04:48 +0200
Subject: [PATCH] Remove empty / duplicated ids that can confuse idiomoprh

---
 app/views/events/event/_layout.html.erb          | 1 +
 app/views/events/index/_filter.html.erb          | 2 +-
 app/views/filters/settings/_assignees.html.erb   | 2 +-
 app/views/filters/settings/_closers.html.erb     | 2 +-
 app/views/filters/settings/_collections.html.erb | 2 +-
 app/views/filters/settings/_creators.html.erb    | 2 +-
 app/views/filters/settings/_tags.html.erb        | 2 +-
 7 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/app/views/events/event/_layout.html.erb b/app/views/events/event/_layout.html.erb
index e278f1566..60700bb53 100644
--- a/app/views/events/event/_layout.html.erb
+++ b/app/views/events/event/_layout.html.erb
@@ -1,4 +1,5 @@
 <%= link_to event.notifiable_target,
+      id: dom_id(event, "timelined"),
       class: "event event--#{ event.action } #{ "golden-effect" if event.card.golden? } center-block flex flex-column full-width align-start justify-start position-relative",
       style: "--card-color: #{ card.closed? ? "var(--color-card-complete)" : card.color };",
       target: "_top",
diff --git a/app/views/events/index/_filter.html.erb b/app/views/events/index/_filter.html.erb
index 22572b40a..729131899 100644
--- a/app/views/events/index/_filter.html.erb
+++ b/app/views/events/index/_filter.html.erb
@@ -22,7 +22,7 @@
           <strong class="popup__title">Collection…</strong>
 
           <% if user_filtering.collections.many? %>
-            <%= text_field_tag nil, nil, placeholder: "Filter…", class: "input input--transparent txt-small font-weight-normal", autofocus: true,
+            <%= text_field_tag nil, nil, id: nil, placeholder: "Filter…", class: "input input--transparent txt-small font-weight-normal", autofocus: true,
                   type: "search", autocorrect: "off", autocomplete: "off", data: { "1p-ignore": "true", filter_target: "input", action: "input->filter#filter" } %>
           <% end %>
 
diff --git a/app/views/filters/settings/_assignees.html.erb b/app/views/filters/settings/_assignees.html.erb
index aa3c1569f..0df432c3d 100644
--- a/app/views/filters/settings/_assignees.html.erb
+++ b/app/views/filters/settings/_assignees.html.erb
@@ -19,7 +19,7 @@
       <strong class="popup__title">Assigned to…</strong>
 
       <% if User.active.many? %>
-        <%= text_field_tag nil, nil, placeholder: "Filter…", class: "input input--transparent txt-small", autofocus: true,
+        <%= text_field_tag nil, nil, id: nil, placeholder: "Filter…", class: "input input--transparent txt-small", autofocus: true,
               type: "search", autocorrect: "off", autocomplete: "off", data: { "1p-ignore": "true", filter_target: "input", action: "input->filter#filter" } %>
       <% end %>
 
diff --git a/app/views/filters/settings/_closers.html.erb b/app/views/filters/settings/_closers.html.erb
index d08e2feaa..2c34b939c 100644
--- a/app/views/filters/settings/_closers.html.erb
+++ b/app/views/filters/settings/_closers.html.erb
@@ -20,7 +20,7 @@
       <strong class="popup__title">Closed by…</strong>
 
       <% if user_filtering.users.many? %>
-        <%= text_field_tag nil, nil, placeholder: "Filter…", class: "input input--transparent txt-small", autofocus: true,
+        <%= text_field_tag nil, nil, id: nil, placeholder: "Filter…", class: "input input--transparent txt-small", autofocus: true,
               type: "search", autocorrect: "off", autocomplete: "off", data: { "1p-ignore": "true", filter_target: "input", action: "input->filter#filter" } %>
       <% end %>
 
diff --git a/app/views/filters/settings/_collections.html.erb b/app/views/filters/settings/_collections.html.erb
index c1bf2d9c2..80a0811e2 100644
--- a/app/views/filters/settings/_collections.html.erb
+++ b/app/views/filters/settings/_collections.html.erb
@@ -20,7 +20,7 @@
       <strong class="popup__title">Collection…</strong>
 
       <% if user_filtering.collections.many? %>
-        <%= text_field_tag nil, nil, placeholder: "Filter…", class: "input input--transparent txt-small", autofocus: true,
+        <%= text_field_tag nil, nil, id: nil, placeholder: "Filter…", class: "input input--transparent txt-small", autofocus: true,
               type: "search", autocorrect: "off", autocomplete: "off", data: { "1p-ignore": "true", filter_target: "input", action: "input->filter#filter" } %>
       <% end %>
 
diff --git a/app/views/filters/settings/_creators.html.erb b/app/views/filters/settings/_creators.html.erb
index bde323a90..7477fdd41 100644
--- a/app/views/filters/settings/_creators.html.erb
+++ b/app/views/filters/settings/_creators.html.erb
@@ -20,7 +20,7 @@
       <strong class="popup__title">Added by…</strong>
 
       <% if user_filtering.users.many? %>
-        <%= text_field_tag nil, nil, placeholder: "Filter…", class: "input input--transparent txt-small", autofocus: true,
+        <%= text_field_tag nil, nil, id: nil, placeholder: "Filter…", class: "input input--transparent txt-small", autofocus: true,
               type: "search", autocorrect: "off", autocomplete: "off", data: { "1p-ignore": "true", filter_target: "input", action: "input->filter#filter" } %>
       <% end %>
 
diff --git a/app/views/filters/settings/_tags.html.erb b/app/views/filters/settings/_tags.html.erb
index 31d75bf2a..da29a436e 100644
--- a/app/views/filters/settings/_tags.html.erb
+++ b/app/views/filters/settings/_tags.html.erb
@@ -19,7 +19,7 @@
       <strong class="popup__title">Tagged…</strong>
 
       <% if user_filtering.tags.many? %>
-        <%= text_field_tag nil, nil, placeholder: "Filter…", class: "input input--transparent txt-small", autofocus: true,
+        <%= text_field_tag nil, nil, id: nil, placeholder: "Filter…", class: "input input--transparent txt-small", autofocus: true,
               type: "search", autocorrect: "off", autocomplete: "off", data: { "1p-ignore": "true", filter_target: "input", action: "input->filter#filter" } %>
       <% end %>