Update tests with final method naming: record! -> record
This commit is contained in:
@@ -7,7 +7,7 @@ class Storage::EntryTest < ActiveSupport::TestCase
|
||||
@card = cards(:logo)
|
||||
end
|
||||
|
||||
test "record! creates entry with positive delta" do
|
||||
test "record creates entry with positive delta" do
|
||||
assert_difference "Storage::Entry.count", +1 do
|
||||
entry = Storage::Entry.record \
|
||||
account: @account,
|
||||
@@ -25,7 +25,7 @@ class Storage::EntryTest < ActiveSupport::TestCase
|
||||
end
|
||||
end
|
||||
|
||||
test "record! creates entry with negative delta" do
|
||||
test "record creates entry with negative delta" do
|
||||
entry = Storage::Entry.record \
|
||||
account: @account,
|
||||
board: @board,
|
||||
@@ -37,7 +37,7 @@ class Storage::EntryTest < ActiveSupport::TestCase
|
||||
assert_equal "detach", entry.operation
|
||||
end
|
||||
|
||||
test "record! returns nil and creates no entry when delta is zero" do
|
||||
test "record returns nil and creates no entry when delta is zero" do
|
||||
assert_no_difference "Storage::Entry.count" do
|
||||
result = Storage::Entry.record \
|
||||
account: @account,
|
||||
@@ -50,7 +50,7 @@ class Storage::EntryTest < ActiveSupport::TestCase
|
||||
end
|
||||
end
|
||||
|
||||
test "record! accepts _id params for after_destroy_commit snapshots" do
|
||||
test "record accepts _id params for after_destroy_commit snapshots" do
|
||||
entry = Storage::Entry.record \
|
||||
account_id: @account.id,
|
||||
board_id: @board.id,
|
||||
@@ -65,7 +65,7 @@ class Storage::EntryTest < ActiveSupport::TestCase
|
||||
assert_equal @card.id, entry.recordable_id
|
||||
end
|
||||
|
||||
test "record! creates entry without board" do
|
||||
test "record creates entry without board" do
|
||||
entry = Storage::Entry.record \
|
||||
account: @account,
|
||||
board: nil,
|
||||
@@ -76,7 +76,7 @@ class Storage::EntryTest < ActiveSupport::TestCase
|
||||
assert_nil entry.board_id
|
||||
end
|
||||
|
||||
test "record! creates entry without recordable" do
|
||||
test "record creates entry without recordable" do
|
||||
entry = Storage::Entry.record \
|
||||
account: @account,
|
||||
board: @board,
|
||||
@@ -88,7 +88,7 @@ class Storage::EntryTest < ActiveSupport::TestCase
|
||||
assert_nil entry.recordable_id
|
||||
end
|
||||
|
||||
test "record! enqueues MaterializeJob for account" do
|
||||
test "record enqueues MaterializeJob for account" do
|
||||
assert_enqueued_with job: Storage::MaterializeJob, args: [ @account ] do
|
||||
Storage::Entry.record \
|
||||
account: @account,
|
||||
@@ -99,7 +99,7 @@ class Storage::EntryTest < ActiveSupport::TestCase
|
||||
end
|
||||
end
|
||||
|
||||
test "record! enqueues MaterializeJob for board when board_id present" do
|
||||
test "record enqueues MaterializeJob for board when board_id present" do
|
||||
assert_enqueued_with job: Storage::MaterializeJob, args: [ @board ] do
|
||||
Storage::Entry.record \
|
||||
account: @account,
|
||||
@@ -110,7 +110,7 @@ class Storage::EntryTest < ActiveSupport::TestCase
|
||||
end
|
||||
end
|
||||
|
||||
test "record! does not enqueue job when account is deleted" do
|
||||
test "record does not enqueue job when account is deleted" do
|
||||
# The graceful handling is that find_by returns nil, so no job is enqueued
|
||||
# for a non-existent account. We can't test with a fake ID due to FK constraints,
|
||||
# but we can verify the find_by behavior by stubbing.
|
||||
@@ -124,7 +124,7 @@ class Storage::EntryTest < ActiveSupport::TestCase
|
||||
end
|
||||
end
|
||||
|
||||
test "record! does not enqueue board job when board is deleted" do
|
||||
test "record does not enqueue board job when board is deleted" do
|
||||
Board.stubs(:find_by).returns(nil)
|
||||
|
||||
# Account job still enqueued, but board job is not
|
||||
|
||||
Reference in New Issue
Block a user