Avoid string manipulation when autolinking.
Instead, let's use a Loofah scrubber which will create DOM nodes directly. This should be faster and is a tiny bit simpler, as well as removing a potential HTML injection vector. Also, add "noreferrer" to all `mailto:` links (already present on URLs).
This commit is contained in:
@@ -0,0 +1,79 @@
|
||||
# Loofah scrubber to auto-link URLs and email addresses in HTML text nodes.
|
||||
#
|
||||
# This scrubber does not perform HTML sanitization; it's assumed that the input is already sanitized
|
||||
# (for example, ActionText rich text).
|
||||
class AutoLinkScrubber < Loofah::Scrubber
|
||||
EXCLUDED_ELEMENTS = %w[a figcaption pre code].freeze
|
||||
|
||||
# This regexp is similar to URI::MailTo::EMAIL_REGEXP but uses \b word boundaries instead of \A/\z
|
||||
# anchors, allowing it to match email addresses embedded within longer strings.
|
||||
#
|
||||
# It's named EMAIL_AUTOLINK_REGEXP (not EMAIL_REGEXP) to avoid confusing Brakeman's imprecise
|
||||
# constant lookup, which otherwise assumes Identity's email validation uses this \b-anchored pattern.
|
||||
# See https://github.com/presidentbeef/brakeman/pull/1981
|
||||
EMAIL_AUTOLINK_REGEXP = /\b[a-zA-Z0-9.!#$%&'*+\/=?^_`{|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\.[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)*\b/
|
||||
URL_REGEXP = URI::DEFAULT_PARSER.make_regexp(%w[http https])
|
||||
AUTOLINK_REGEXP = /(?<url>#{URL_REGEXP})|(?<email>#{EMAIL_AUTOLINK_REGEXP})/
|
||||
|
||||
TRAILING_PUNCTUATION = %(.?,:!;"'<>)
|
||||
TRAILING_PUNCTUATION_REGEXP = /[#{Regexp.escape(TRAILING_PUNCTUATION)}]+\z/
|
||||
|
||||
def initialize
|
||||
@direction = :top_down
|
||||
end
|
||||
|
||||
def scrub(node)
|
||||
return Loofah::Scrubber::STOP if EXCLUDED_ELEMENTS.include?(node.name)
|
||||
|
||||
if node.text?
|
||||
replacement = autolink_text_node(node)
|
||||
node.replace(replacement) if replacement
|
||||
end
|
||||
|
||||
Loofah::Scrubber::CONTINUE
|
||||
end
|
||||
|
||||
private
|
||||
def autolink_text_node(node)
|
||||
text = node.text
|
||||
links = find_links(text)
|
||||
|
||||
return nil if links.empty?
|
||||
|
||||
doc = node.document
|
||||
nodes = Nokogiri::XML::NodeSet.new(doc)
|
||||
pos = 0
|
||||
|
||||
links.each do |link|
|
||||
nodes << doc.create_text_node(text[pos...link[:start]]) if link[:start] > pos
|
||||
nodes << doc.create_element("a", link[:text], href: link[:href], rel: "noreferrer")
|
||||
pos = link[:start] + link[:length]
|
||||
end
|
||||
nodes << doc.create_text_node(text[pos..]) if pos < text.length
|
||||
|
||||
nodes
|
||||
end
|
||||
|
||||
def find_links(text)
|
||||
links = []
|
||||
|
||||
text.scan(AUTOLINK_REGEXP) do
|
||||
match_data = Regexp.last_match
|
||||
start_pos = match_data.begin(0)
|
||||
|
||||
if match_data[:url]
|
||||
url = clean_url(match_data[:url])
|
||||
links << { start: start_pos, length: url.length, text: url, href: url }
|
||||
else
|
||||
email = match_data[:email]
|
||||
links << { start: start_pos, length: email.length, text: email, href: "mailto:#{email}" }
|
||||
end
|
||||
end
|
||||
|
||||
links
|
||||
end
|
||||
|
||||
def clean_url(url)
|
||||
url.sub(TRAILING_PUNCTUATION_REGEXP, "")
|
||||
end
|
||||
end
|
||||
Reference in New Issue
Block a user