Add SearchReindexJob to repopulate the search index (#2850)

Rebuilds search records for every published Card and every Comment on a published Card. Intended for manual invocation after a search-index loss event — not a recurring job. Uses ActiveJob::Continuable so the work survives worker restarts and resumes from the last-processed id. The job is idempotent. Removes script/maintenance/reindex_stale_search_records.rb, which was written against a different hypothesis (a date-cutoff backfill) and is superseded by this unconditional repair job.
2026-04-16 19:40:02 -04:00
parent 9a27ca8b42
commit 466b215ef8
3 changed files with 142 additions and 39 deletions
@@ -0,0 +1,82 @@
+require "test_helper"
+
+class SearchReindexJobTest < ActiveJob::TestCase
+  test "reindexes cards and comments after their search records are nuked" do
+    card = cards(:logo)
+    comment = comments(:logo_1)
+
+    card.reindex
+    comment.reindex
+
+    card_shard = Search::Record.for(card.account_id)
+    comment_shard = Search::Record.for(comment.account_id)
+
+    assert card_shard.exists?(searchable_type: "Card", searchable_id: card.id)
+    assert comment_shard.exists?(searchable_type: "Comment", searchable_id: comment.id)
+
+    card_shard.delete_all
+    comment_shard.delete_all unless comment_shard == card_shard
+
+    assert_not card_shard.exists?(searchable_type: "Card", searchable_id: card.id)
+    assert_not comment_shard.exists?(searchable_type: "Comment", searchable_id: comment.id)
+
+    SearchReindexJob.perform_now
+
+    assert card_shard.exists?(searchable_type: "Card", searchable_id: card.id)
+    assert comment_shard.exists?(searchable_type: "Comment", searchable_id: comment.id)
+  end
+
+  test "skips records whose rich text exceeds rich_text_limit" do
+    Current.account = accounts(:"37s")
+    Current.session = Session.new(identity: identities(:david))
+
+    big_card = boards(:writebook).cards.create!(
+      creator: users(:david),
+      title: "too big to index",
+      status: :published,
+      description: "x" * 5_000
+    )
+
+    nuke_search_records
+
+    SearchReindexJob.perform_now(rich_text_limit: 1_000)
+
+    shard = Search::Record.for(big_card.account_id)
+    assert_not shard.exists?(searchable_type: "Card", searchable_id: big_card.id)
+  end
+
+  test "does not index drafted cards or their comments" do
+    Current.account = accounts(:"37s")
+    Current.session = Session.new(identity: identities(:david))
+
+    card = boards(:writebook).cards.create!(
+      creator: users(:david),
+      title: "will be drafted",
+      status: :published
+    )
+    comment = card.comments.create!(creator: users(:david), body: "on a card that will be drafted")
+    card.update!(status: :drafted)
+
+    nuke_search_records
+
+    SearchReindexJob.perform_now
+
+    shard = Search::Record.for(card.account_id)
+    assert_not shard.exists?(searchable_type: "Card", searchable_id: card.id)
+    assert_not shard.exists?(searchable_type: "Comment", searchable_id: comment.id)
+  end
+
+  private
+    def sqlite?
+      ActiveRecord::Base.connection.adapter_name == "SQLite"
+    end
+
+    def nuke_search_records
+      if sqlite?
+        ActiveRecord::Base.connection.execute("DELETE FROM search_records")
+        ActiveRecord::Base.connection.execute("DELETE FROM search_records_fts")
+      else
+        Search::Record::Trilogy::SHARD_CLASSES.each(&:delete_all)
+      end
+    end
+end