From 4ab1e3ff7d481075e1da4bc071c9e9c3283b8863 Mon Sep 17 00:00:00 2001 From: Jorge Manrubia Date: Fri, 16 Jan 2026 17:17:50 +0100 Subject: [PATCH] Solve problem when Action Text raises on missing attachables Reverts the previous patch. The problem was that I hadn't update Lexxy in the saas version https://github.com/basecamp/lexxy/pull/596 --- Gemfile.saas.lock | 2 +- .../attachables/_missing_attachable.html.erb | 1 - test/controllers/cards_controller_test.rb | 10 ++++++++++ 3 files changed, 11 insertions(+), 2 deletions(-) delete mode 100644 app/views/cards/action_text/attachables/_missing_attachable.html.erb diff --git a/Gemfile.saas.lock b/Gemfile.saas.lock index 2153cbdfa..0b0e79cb8 100644 --- a/Gemfile.saas.lock +++ b/Gemfile.saas.lock @@ -21,7 +21,7 @@ GIT GIT remote: https://github.com/basecamp/lexxy - revision: 2fafd144924c95c25bd4c6656ae04034f7835494 + revision: 4f0fc4d5773bc6892de70f175440c259974c12a7 specs: lexxy (0.7.0.beta) rails (>= 8.0.2) diff --git a/app/views/cards/action_text/attachables/_missing_attachable.html.erb b/app/views/cards/action_text/attachables/_missing_attachable.html.erb deleted file mode 100644 index 5ffd93b89..000000000 --- a/app/views/cards/action_text/attachables/_missing_attachable.html.erb +++ /dev/null @@ -1 +0,0 @@ -<%= "☒" -%> diff --git a/test/controllers/cards_controller_test.rb b/test/controllers/cards_controller_test.rb index 11c4b62a5..8540912e6 100644 --- a/test/controllers/cards_controller_test.rb +++ b/test/controllers/cards_controller_test.rb @@ -52,6 +52,16 @@ class CardsControllerTest < ActionDispatch::IntegrationTest assert_response :success end + test "edit card with invalid attachments in description" do + card = cards(:logo) + card.update! description: <<~HTML + + HTML + + get edit_card_path(card) + assert_response :success + end + test "update" do patch card_path(cards(:logo)), as: :turbo_stream, params: { card: {