From 4dc28943da446b2c57ac9d81fdce53fa28081634 Mon Sep 17 00:00:00 2001 From: Mike Dalessio Date: Sat, 22 Nov 2025 09:40:27 -0500 Subject: [PATCH] Don't let cloudflare cache avatars The issue here is that anyone else who views my avatar will cause it to be cached, and then I can't easily bust the cache if I change my avatar. --- app/controllers/users/avatars_controller.rb | 2 +- test/controllers/users/avatars_controller_test.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/controllers/users/avatars_controller.rb b/app/controllers/users/avatars_controller.rb index 39dda87f8..9101ee401 100644 --- a/app/controllers/users/avatars_controller.rb +++ b/app/controllers/users/avatars_controller.rb @@ -32,7 +32,7 @@ class Users::AvatarsController < ApplicationController if @user == Current.user {} else - { max_age: 30.minutes, stale_while_revalidate: 1.week, public: true } + { max_age: 30.minutes, stale_while_revalidate: 1.week } end end diff --git a/test/controllers/users/avatars_controller_test.rb b/test/controllers/users/avatars_controller_test.rb index 9d39c0fa9..304825639 100644 --- a/test/controllers/users/avatars_controller_test.rb +++ b/test/controllers/users/avatars_controller_test.rb @@ -15,7 +15,7 @@ class Users::AvatarsControllerTest < ActionDispatch::IntegrationTest test "show other initials with caching" do get user_avatar_path(users(:kevin)) assert_match "image/svg+xml", @response.content_type - assert @response.cache_control[:public] + assert @response.cache_control[:private] assert_equal 30.minutes.to_s, @response.cache_control[:max_age] end