bterkuile/fizzy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Move category and high_priority to payload classes

Browse Source 
Use polymorphism instead of case statements in Native push target:
- DefaultPayload#category returns "default", #high_priority? returns false
- EventPayload#category returns "assignment"/"comment"/"card" based on action
- MentionPayload#category returns "mention", #high_priority? returns true

This simplifies the Native push target by delegating source-specific
logic to the appropriate payload classes.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Rosa Gutierrez
2026-01-22 13:19:18 +01:00
parent 9299300dbf
commit 4f19c42958
5 changed files with 43 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files
saas/test/models/notification/push_target/native_test.rb
+8 -21
View File
@@ -10,39 +10,26 @@ class Notification::PushTarget::NativeTest < ActiveSupport::TestCase
@user.push_subscriptions.delete_all
end
test "notification_category returns assignment for card_assigned" do
test "payload category returns assignment for card_assigned" do
notification = notifications(:logo_assignment_kevin)
@identity.devices.create!(token: "test123", platform: "apple", name: "Test iPhone")
push = Notification::PushTarget::Native.new(notification)
assert_equal "assignment", push.send(:notification_category)
assert_equal "assignment", notification.payload.category
end
test "notification_category returns comment for comment_created" do
test "payload category returns comment for comment_created" do
notification = notifications(:layout_commented_kevin)
@identity.devices.create!(token: "test123", platform: "apple", name: "Test iPhone")
push = Notification::PushTarget::Native.new(notification)
assert_equal "comment", push.send(:notification_category)
assert_equal "comment", notification.payload.category
end
test "notification_category returns mention for mentions" do
test "payload category returns mention for mentions" do
notification = notifications(:logo_card_david_mention_by_jz)
notification.user.identity.devices.create!(token: "test123", platform: "apple", name: "Test iPhone")
push = Notification::PushTarget::Native.new(notification)
assert_equal "mention", push.send(:notification_category)
assert_equal "mention", notification.payload.category
end
test "notification_category returns card for other card events" do
@identity.devices.create!(token: "test123", platform: "apple", name: "Test iPhone")
push = Notification::PushTarget::Native.new(@notification)
assert_equal "card", push.send(:notification_category)
test "payload category returns card for other card events" do
assert_equal "card", @notification.payload.category
end