From 5048e9c9700c45ea85193c50843b6a1440ae8889 Mon Sep 17 00:00:00 2001 From: David Heinemeier Hansson Date: Tue, 22 Apr 2025 21:40:30 +0200 Subject: [PATCH] Duh, no before destroy commit, but this is still not right! --- app/models/concerns/filterable.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/models/concerns/filterable.rb b/app/models/concerns/filterable.rb index e1a11abd8..85a33a015 100644 --- a/app/models/concerns/filterable.rb +++ b/app/models/concerns/filterable.rb @@ -5,10 +5,12 @@ module Filterable has_and_belongs_to_many :filters after_update { filters.touch_all } - before_destroy_commit :remove_from_filters + before_destroy :remove_from_filters end private + # FIXME: This is too inefficient to have part of a destroy transaction. + # Need to find a way to use a job or a single query. def remove_from_filters filters.each { it.resource_removed self } end