From 56fbabb374f951ce348e248d0729024eaddf3a37 Mon Sep 17 00:00:00 2001
From: Jorge Manrubia <jorge@37signals.com>
Date: Thu, 21 Aug 2025 16:01:45 +0200
Subject: [PATCH] Extract helper

---
 app/helpers/filters_helper.rb           | 10 +++++
 app/views/filters/menu/_places.html.erb | 53 +++----------------------
 2 files changed, 16 insertions(+), 47 deletions(-)

diff --git a/app/helpers/filters_helper.rb b/app/helpers/filters_helper.rb
index f281c1007..ff326ea96 100644
--- a/app/helpers/filters_helper.rb
+++ b/app/helpers/filters_helper.rb
@@ -14,4 +14,14 @@ module FiltersHelper
   def filter_selected_collections_title(user_filtering)
     user_filtering.selected_collection_titles.collect { tag.strong it }.to_sentence.html_safe
   end
+
+  def filter_place_menu_item(path, label, icon)
+    tag.li class: "popup__group", data: { filter_target: "item", navigable_list_target: "item" } do
+      concat icon_tag(icon)
+      concat(link_to(path, class: "popup__item btn") do
+        concat tag.span(label, class: "overflow-ellipsis")
+        concat tag.span(" ›", class: "translucent flex-item-no-shrink flex-item-justify-end")
+      end)
+    end
+  end
 end
diff --git a/app/views/filters/menu/_places.html.erb b/app/views/filters/menu/_places.html.erb
index 96bc66e10..f5a295207 100644
--- a/app/views/filters/menu/_places.html.erb
+++ b/app/views/filters/menu/_places.html.erb
@@ -1,52 +1,11 @@
 <ul class="popup__list">
   <li class="popup__group-title">Jump to…</li>
 
-  <li class="popup__group" data-filter-target="item" data-navigable-list-target="item">
-    <%= icon_tag "settings" %>
-    <%= link_to account_settings_path, class: "popup__item btn" do %>
-      <span class="overflow-ellipsis">Account Settings</span>
-      <span class="translucent flex-item-no-shrink flex-item-justify-end"> ›</span>
-    <% end %>
-  </li>
-
-  <li class="popup__group" data-filter-target="item" data-navigable-list-target="item">
-    <%= icon_tag "person" %>
-    <%= link_to user_path(Current.user), class: "popup__item btn" do %>
-      <span class="overflow-ellipsis">My Profile</span>
-      <span class="translucent flex-item-no-shrink flex-item-justify-end"> ›</span>
-    <% end %>
-  </li>
-
-  <li class="popup__group" data-filter-target="item" data-navigable-list-target="item">
-    <%= icon_tag "bell" %>
-    <%= link_to notifications_path, class: "popup__item btn" do %>
-      <span class="overflow-ellipsis">Notifications</span>
-      <span class="translucent flex-item-no-shrink flex-item-justify-end"> ›</span>
-    <% end %>
-  </li>
-
-  <li class="popup__group" data-filter-target="item" data-navigable-list-target="item">
-    <%= icon_tag "settings" %>
-    <%= link_to settings_notifications_path, class: "popup__item btn" do %>
-      <span class="overflow-ellipsis">Notification Settings</span>
-      <span class="translucent flex-item-no-shrink flex-item-justify-end"> ›</span>
-    <% end %>
-  </li>
-
-  <li class="popup__group" data-filter-target="item" data-navigable-list-target="item">
-    <%= icon_tag "search" %>
-    <%= link_to search_path, class: "popup__item btn" do %>
-      <span class="overflow-ellipsis">Search</span>
-      <span class="translucent flex-item-no-shrink flex-item-justify-end"> ›</span>
-    <% end %>
-  </li>
-
-  <li class="popup__group" data-filter-target="item" data-navigable-list-target="item">
-    <%= icon_tag "bolt" %>
-    <%= link_to workflows_path, class: "popup__item btn" do %>
-      <span class="overflow-ellipsis">Workflows</span>
-      <span class="translucent flex-item-no-shrink flex-item-justify-end"> ›</span>
-    <% end %>
-  </li>
+  <%= filter_place_menu_item account_settings_path, "Account Settings", "settings" %>
+  <%= filter_place_menu_item user_path(Current.user), "My Profile", "person" %>
+  <%= filter_place_menu_item notifications_path, "Notifications", "bell" %>
+  <%= filter_place_menu_item settings_notifications_path, "Notification Settings", "settings" %>
+  <%= filter_place_menu_item search_path, "Search", "search" %>
+  <%= filter_place_menu_item workflows_path, "Workflows", "bolt" %>
 </ul>