From 3b83d218ea5335b0a72178703f02b0ea78048608 Mon Sep 17 00:00:00 2001
From: Jorge Manrubia <jorge@hey.com>
Date: Fri, 19 Sep 2025 17:42:48 +0200
Subject: [PATCH] Restore filter targets so that search works!

---
 app/views/filters/settings/_assignees.html.erb | 4 ++--
 app/views/filters/settings/_closers.html.erb   | 2 +-
 app/views/filters/settings/_creators.html.erb  | 2 +-
 app/views/filters/settings/_tags.html.erb      | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/app/views/filters/settings/_assignees.html.erb b/app/views/filters/settings/_assignees.html.erb
index 80035e7aa..5a2400b40 100644
--- a/app/views/filters/settings/_assignees.html.erb
+++ b/app/views/filters/settings/_assignees.html.erb
@@ -25,7 +25,7 @@
 
       <ul class="popup__list" data-filter-target="list" role="listbox">
         <%= tag.li class: "popup__item", data: {
-              navigable_list_target: "item", multi_selection_combobox_target: "item", multi_selection_combobox_value: "unassigned", multi_selection_combobox_label: "No one" },
+              filter_target: "item", navigable_list_target: "item", multi_selection_combobox_target: "item", multi_selection_combobox_value: "unassigned", multi_selection_combobox_label: "No one" },
               role: "checkbox", aria: { checked: filter.assignment_status.unassigned? } do %>
           <button type="button" class="btn popup__btn" data-action="dialog#close multi-selection-combobox#clear form#submit filter-settings#change">
             <span class="overflow-ellipsis flex-item-grow">No one</span>
@@ -35,7 +35,7 @@
 
         <% user_filtering.users.each do |user| %>
           <%= tag.li class: "popup__item", data: {
-                navigable_list_target: "item", multi_selection_combobox_target: "item", multi_selection_combobox_value: user.id, multi_selection_combobox_label: user.familiar_name },
+                filter_target: "item", navigable_list_target: "item", multi_selection_combobox_target: "item", multi_selection_combobox_value: user.id, multi_selection_combobox_label: user.familiar_name },
                 role: "checkbox", aria: { checked: filter.assignees.include?(user) } do %>
             <button type="button" class="btn popup__btn" data-action="dialog#close multi-selection-combobox#change form#submit filter-settings#change">
               <span class="overflow-ellipsis flex-item-grow"><%= user.name %></span>
diff --git a/app/views/filters/settings/_closers.html.erb b/app/views/filters/settings/_closers.html.erb
index 411d35df9..df40dea9d 100644
--- a/app/views/filters/settings/_closers.html.erb
+++ b/app/views/filters/settings/_closers.html.erb
@@ -27,7 +27,7 @@
       <ul class="popup__list" data-filter-target="list" role="listbox">
         <% user_filtering.users.each do |user| %>
           <%= tag.li class: "popup__item", data: {
-                navigable_list_target: "item", multi_selection_combobox_target: "item", multi_selection_combobox_value: user.id, multi_selection_combobox_label: user.familiar_name },
+                filter_target: "item", navigable_list_target: "item", multi_selection_combobox_target: "item", multi_selection_combobox_value: user.id, multi_selection_combobox_label: user.familiar_name },
                 role: "checkbox", aria: { checked: filter.closers.include?(user) } do %>
             <button type="button" class="btn popup__btn" data-action="dialog#close multi-selection-combobox#change form#submit filter-settings#change">
               <span class="overflow-ellipsis flex-item-grow"><%= user.name %></span>
diff --git a/app/views/filters/settings/_creators.html.erb b/app/views/filters/settings/_creators.html.erb
index e4da836b9..6092e2b54 100644
--- a/app/views/filters/settings/_creators.html.erb
+++ b/app/views/filters/settings/_creators.html.erb
@@ -27,7 +27,7 @@
       <ul class="popup__list" data-filter-target="list" role="listbox">
         <% user_filtering.users.each do |user| %>
           <%= tag.li class: "popup__item", data: {
-                navigable_list_target: "item", multi_selection_combobox_target: "item", multi_selection_combobox_value: user.id, multi_selection_combobox_label: user.familiar_name },
+                filter_target: "item", navigable_list_target: "item", multi_selection_combobox_target: "item", multi_selection_combobox_value: user.id, multi_selection_combobox_label: user.familiar_name },
                 role: "checkbox", aria: { checked: filter.creators.include?(user) } do %>
             <button type="button" class="btn popup__btn" data-action="dialog#close multi-selection-combobox#change form#submit filter-settings#change">
               <span class="overflow-ellipsis flex-item-grow"><%= user.name %></span>
diff --git a/app/views/filters/settings/_tags.html.erb b/app/views/filters/settings/_tags.html.erb
index e3f730383..a10d4f531 100644
--- a/app/views/filters/settings/_tags.html.erb
+++ b/app/views/filters/settings/_tags.html.erb
@@ -26,7 +26,7 @@
       <ul class="popup__list" data-filter-target="list" role="listbox">
         <% user_filtering.tags.each do |tag| %>
           <%= content_tag(:li, class: "popup__item", data: {
-                navigable_list_target: "item", multi_selection_combobox_target: "item", multi_selection_combobox_value: tag.id, multi_selection_combobox_label: tag.hashtag },
+                filter_target: "item", navigable_list_target: "item", multi_selection_combobox_target: "item", multi_selection_combobox_value: tag.id, multi_selection_combobox_label: tag.hashtag },
                 role: "checkbox", aria: { checked: filter.tags.include?(tag) }) do %>
             <button type="button" class="btn popup__btn" data-action="dialog#close multi-selection-combobox#change form#submit filter-settings#change">
               <span class="overflow-ellipsis flex-item-grow"><%= tag.hashtag %></span>