From 5da1dee4500b066f23da0bea3d3fcda9feddb1c2 Mon Sep 17 00:00:00 2001
From: Andy Smith <andy@37signals.com>
Date: Wed, 13 Aug 2025 12:20:39 -0500
Subject: [PATCH] Only add selected BG color when it makes sense

---
 app/assets/stylesheets/settings.css | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/app/assets/stylesheets/settings.css b/app/assets/stylesheets/settings.css
index 983034a03..f2f1be59e 100644
--- a/app/assets/stylesheets/settings.css
+++ b/app/assets/stylesheets/settings.css
@@ -67,10 +67,6 @@
       /* Add padding if it's not already on a link within */
       &:not(:has(a:first-child)) { padding-inline-end: var(--settings-item-padding-inline); }
       &:not(:has(a:last-child)) { padding-inline-end: var(--settings-item-padding-inline); }
-
-      &[aria-selected] {
-        background: var(--color-selected);
-      }
     }
 
     a {
@@ -82,5 +78,12 @@
         }
       }
     }
+
+    /* Only add a BG color when you can actually navigate */
+    .settings__user-filter:focus-within & {
+      [aria-selected] {
+        background: var(--color-selected);
+      }
+    }
   }
 }