From 680a69ad29c36b00b21081a73c34b50a758ce8e1 Mon Sep 17 00:00:00 2001
From: "Stanko K.R." <stanko@stanko.io>
Date: Fri, 12 Sep 2025 15:51:23 +0200
Subject: [PATCH] Add tests for webhooks controllers

---
 .../webhooks/activations_controller_test.rb   |  19 +++
 test/controllers/webhooks_controller_test.rb  | 113 ++++++++++++++++++
 test/fixtures/webhooks.yml                    |   4 +-
 3 files changed, 134 insertions(+), 2 deletions(-)
 create mode 100644 test/controllers/webhooks/activations_controller_test.rb
 create mode 100644 test/controllers/webhooks_controller_test.rb

diff --git a/test/controllers/webhooks/activations_controller_test.rb b/test/controllers/webhooks/activations_controller_test.rb
new file mode 100644
index 000000000..228382a64
--- /dev/null
+++ b/test/controllers/webhooks/activations_controller_test.rb
@@ -0,0 +1,19 @@
+require "test_helper"
+
+class Webhooks::ActivationsControllerTest < ActionDispatch::IntegrationTest
+  setup do
+    sign_in_as :kevin
+  end
+
+  test "create" do
+    webhook = webhooks(:inactive)
+
+    assert_not webhook.active?
+
+    assert_changes -> { webhook.reload.active? }, from: false, to: true do
+      post webhook_activation_path(webhook)
+    end
+
+    assert_redirected_to webhook_path(webhook)
+  end
+end
diff --git a/test/controllers/webhooks_controller_test.rb b/test/controllers/webhooks_controller_test.rb
new file mode 100644
index 000000000..dbfab6e79
--- /dev/null
+++ b/test/controllers/webhooks_controller_test.rb
@@ -0,0 +1,113 @@
+require "test_helper"
+
+class WebhooksControllerTest < ActionDispatch::IntegrationTest
+  setup do
+    sign_in_as :kevin
+  end
+
+  test "index" do
+    get webhooks_path
+    assert_response :success
+  end
+
+  test "show" do
+    webhook = webhooks(:active)
+    get webhook_path(webhook)
+    assert_response :success
+  end
+
+  test "new" do
+    get new_webhook_path
+    assert_response :success
+    assert_select "form"
+  end
+
+  test "create with valid params" do
+    assert_difference "Webhook.count", 1 do
+      post webhooks_path, params: {
+        webhook: {
+          name: "Test Webhook",
+          url: "https://example.com/webhook",
+          subscribed_actions: [ "", "card_created", "card_closed" ]
+        }
+      }
+    end
+
+    webhook = Webhook.order(id: :desc).first
+
+    assert_redirected_to webhook_path(webhook)
+    assert_equal "Test Webhook", webhook.name
+    assert_equal "https://example.com/webhook", webhook.url
+    assert_equal [ "card_created", "card_closed" ], webhook.subscribed_actions
+  end
+
+  test "create with invalid params" do
+    assert_no_difference "Webhook.count" do
+      post webhooks_path, params: {
+        webhook: {
+          name: "",
+          url: "invalid-url"
+        }
+      }
+    end
+
+    assert_response :unprocessable_entity
+    assert_select "form"
+  end
+
+  test "edit" do
+    webhook = webhooks(:active)
+    get edit_webhook_path(webhook)
+    assert_response :success
+    assert_select "form"
+  end
+
+  test "update with valid params" do
+    webhook = webhooks(:active)
+    patch webhook_path(webhook), params: {
+      webhook: {
+        name: "Updated Webhook",
+        subscribed_actions: [ "card_created" ]
+      }
+    }
+
+    webhook.reload
+
+    assert_redirected_to webhook_path(webhook)
+    assert_equal "Updated Webhook", webhook.name
+    assert_equal [ "card_created" ], webhook.subscribed_actions
+  end
+
+  test "update with invalid params" do
+    webhook = webhooks(:active)
+    patch webhook_path(webhook), params: {
+      webhook: {
+        name: ""
+      }
+    }
+
+    assert_response :unprocessable_entity
+    assert_select "form"
+
+    assert_no_changes -> { webhook.reload.url } do
+      patch webhook_path(webhook), params: {
+        webhook: {
+          name: "Updated Webhook",
+          url: "https://different.com/webhook"
+        }
+      }
+    end
+
+    assert_redirected_to webhook_path(webhook)
+  end
+
+  test "destroy" do
+    webhook = webhooks(:active)
+
+    assert_difference "Webhook.count", -1 do
+      delete webhook_path(webhook)
+    end
+
+    assert_redirected_to webhooks_path
+  end
+end
diff --git a/test/fixtures/webhooks.yml b/test/fixtures/webhooks.yml
index eaf09613a..4317606fe 100644
--- a/test/fixtures/webhooks.yml
+++ b/test/fixtures/webhooks.yml
@@ -3,11 +3,11 @@ active:
   name: Production API
   url: https://api.example.com/webhooks
   signing_secret: p94Bx2HjempCdYB4DTyZkY1b
-  subscribed_actions: <%= %w[ card_published card_assigned card_closed ].to_json %>
+  subscribed_actions: '<%= %w[ card_published card_assigned card_closed ].to_json %>'
 
 inactive:
   active: false
   name: Test Webhook
   url: https://test.example.com/webhooks
   signing_secret: H8ms8ADcV92v2x17hnLEiL5m
-  subscribed_actions: <%= %w[ card_published card_assigned card_closed ].to_json %>
+  subscribed_actions: '<%= %w[ card_published card_assigned card_closed ].to_json %>'