From 6df681991fb9c12f58a553d80dcd81ad513cff14 Mon Sep 17 00:00:00 2001 From: Mike Dalessio Date: Thu, 13 Nov 2025 10:24:17 -0500 Subject: [PATCH] rubocop: fix style warnings --- app/models/concerns/searchable.rb | 10 +++++----- app/models/search/highlighter.rb | 6 +++--- test/models/card/searchable_test.rb | 6 +++--- test/models/identity_test.rb | 2 +- test/test_helper.rb | 2 +- 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/app/models/concerns/searchable.rb b/app/models/concerns/searchable.rb index a1ee61266..1184131b3 100644 --- a/app/models/concerns/searchable.rb +++ b/app/models/concerns/searchable.rb @@ -62,9 +62,9 @@ module Searchable ]) end - # Models must implement these methods: - # - search_title: returns title string or nil - # - search_content: returns content string - # - search_card_id: returns the card id (self.id for cards, card_id for comments) - # - search_board_id: returns the board id + # Models must implement these methods: + # - search_title: returns title string or nil + # - search_content: returns content string + # - search_card_id: returns the card id (self.id for cards, card_id for comments) + # - search_board_id: returns the board id end diff --git a/app/models/search/highlighter.rb b/app/models/search/highlighter.rb index c62755e94..d2b53d772 100644 --- a/app/models/search/highlighter.rb +++ b/app/models/search/highlighter.rb @@ -28,8 +28,8 @@ class Search::Highlighter if words.length <= max_words highlight(text) elsif match_index - start_index = [0, match_index - max_words / 2].max - end_index = [words.length - 1, start_index + max_words - 1].min + start_index = [ 0, match_index - max_words / 2 ].max + end_index = [ words.length - 1, start_index + max_words - 1 ].min snippet_text = words[start_index..end_index].join(" ") snippet_text = "...#{snippet_text}" if start_index > 0 @@ -50,7 +50,7 @@ class Search::Highlighter terms << phrase.first end - unquoted = query.gsub(/"[^"]+"/, '') + unquoted = query.gsub(/"[^"]+"/, "") unquoted.split(/\s+/).each do |word| terms << word if word.present? end diff --git a/test/models/card/searchable_test.rb b/test/models/card/searchable_test.rb index 99b67a975..1c65606c0 100644 --- a/test/models/card/searchable_test.rb +++ b/test/models/card/searchable_test.rb @@ -27,16 +27,16 @@ class Card::SearchableTest < ActiveSupport::TestCase # Searching by comment card_with_comment = @board.cards.create!(title: "Some card", creator: @user) card_with_comment.comments.create!(body: "overflowing text", creator: @user) - results = Card.mentioning("overflowing", user: @user ) + results = Card.mentioning("overflowing", user: @user) assert_includes results, card_with_comment # Sanitizing search query card_broken = @board.cards.create!(title: "broken layout", creator: @user) - results = Card.mentioning("broken \"", user: @user ) + results = Card.mentioning("broken \"", user: @user) assert_includes results, card_broken # Empty query returns no results - assert_empty Card.mentioning("\"", user: @user ) + assert_empty Card.mentioning("\"", user: @user) # Filtering by board_ids other_board = Board.create!(name: "Other Board", account: @account, creator: @user) diff --git a/test/models/identity_test.rb b/test/models/identity_test.rb index 6d5dbc6ec..972a68e05 100644 --- a/test/models/identity_test.rb +++ b/test/models/identity_test.rb @@ -23,7 +23,7 @@ class IdentityTest < ActiveSupport::TestCase identity = identities(:david) account = accounts(:initech) - assert_difference ["Membership.count", "User.count"], 1 do + assert_difference [ "Membership.count", "User.count" ], 1 do identity.join(account) end diff --git a/test/test_helper.rb b/test/test_helper.rb index 4c46eb758..be753cb74 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -81,7 +81,7 @@ module FixturesTestHelper end # Rails passes :string for varchar columns, so handle both :uuid and :string - return super(label, column_type) unless column_type.in?([:uuid, :string]) + return super(label, column_type) unless column_type.in?([ :uuid, :string ]) generate_fixture_uuid(label) end