From 7427675fc8ef503dcf593da4b73ab70ef6b73d9c Mon Sep 17 00:00:00 2001 From: Jay Ohms Date: Thu, 26 Feb 2026 07:53:02 -0500 Subject: [PATCH] PR feedback --- app/javascript/controllers/bridge/buttons_controller.js | 4 ++++ app/javascript/controllers/bridge/form_controller.js | 4 ++++ app/views/cards/container/_closure.html.erb | 1 + app/views/cards/container/_closure_buttons.html.erb | 2 +- 4 files changed, 10 insertions(+), 1 deletion(-) diff --git a/app/javascript/controllers/bridge/buttons_controller.js b/app/javascript/controllers/bridge/buttons_controller.js index dca0b5ae1..7958b255d 100644 --- a/app/javascript/controllers/bridge/buttons_controller.js +++ b/app/javascript/controllers/bridge/buttons_controller.js @@ -6,6 +6,8 @@ export default class extends BridgeComponent { static targets = [ "button" ] connect() { + super.connect() + if (!this.beforeUnloadHandler) { this.beforeUnloadHandler = this.handleBeforeUnload.bind(this) } @@ -14,6 +16,8 @@ export default class extends BridgeComponent { } disconnect() { + super.disconnect() + if (this.beforeUnloadHandler) { window.removeEventListener("beforeunload", this.beforeUnloadHandler) } diff --git a/app/javascript/controllers/bridge/form_controller.js b/app/javascript/controllers/bridge/form_controller.js index f5f618669..4ebb3022c 100644 --- a/app/javascript/controllers/bridge/form_controller.js +++ b/app/javascript/controllers/bridge/form_controller.js @@ -7,6 +7,8 @@ export default class extends BridgeComponent { static values = { submitTitle: String } connect() { + super.connect() + if (!this.beforeUnloadHandler) { this.beforeUnloadHandler = this.handleBeforeUnload.bind(this) } @@ -15,6 +17,8 @@ export default class extends BridgeComponent { } disconnect() { + super.disconnect() + if (this.beforeUnloadHandler) { window.removeEventListener("beforeunload", this.beforeUnloadHandler) } diff --git a/app/views/cards/container/_closure.html.erb b/app/views/cards/container/_closure.html.erb index 1afbaaaac..6da99c7ee 100644 --- a/app/views/cards/container/_closure.html.erb +++ b/app/views/cards/container/_closure.html.erb @@ -5,6 +5,7 @@ <%= button_to card_closure_path(card), method: :delete, class: "btn btn--plain borderless fill-transparent" do %> Undo <% end %> + <%= bridged_button_to_board(card.board) %> <% else %>
diff --git a/app/views/cards/container/_closure_buttons.html.erb b/app/views/cards/container/_closure_buttons.html.erb index c0f5e4453..27db6590e 100644 --- a/app/views/cards/container/_closure_buttons.html.erb +++ b/app/views/cards/container/_closure_buttons.html.erb @@ -14,5 +14,5 @@ d <% end %> - <%= bridged_button_to_board(@card.board) %> + <%= bridged_button_to_board(card.board) %>