From d3a01cf9bb479d613fb9af97bbd6f571e9106da9 Mon Sep 17 00:00:00 2001
From: Jason Zimdars <jz@37signals.com>
Date: Thu, 24 Jul 2025 14:58:52 -0500
Subject: [PATCH] Dialog target needs to be in the DOM on connect

Moves it out of the turbo frame so it's available even when empty
---
 app/views/cards/display/perma/_tags.html.erb | 4 +++-
 app/views/cards/taggings/new.html.erb        | 5 ++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/app/views/cards/display/perma/_tags.html.erb b/app/views/cards/display/perma/_tags.html.erb
index 4e870078c..527c579c5 100644
--- a/app/views/cards/display/perma/_tags.html.erb
+++ b/app/views/cards/display/perma/_tags.html.erb
@@ -17,6 +17,8 @@
       <span class="for-screen-reader">Add a tag</span>
     </button>
 
-    <%= turbo_frame_tag card, :tagging, src: new_card_tagging_path(card) %>
+    <dialog class="popup panel flex-column align-start justify-start fill-white shadow txt-small" data-dialog-target="dialog">
+      <%= turbo_frame_tag card, :tagging, src: new_card_tagging_path(card) %>
+    </dialog>
   </div>
 </div>
diff --git a/app/views/cards/taggings/new.html.erb b/app/views/cards/taggings/new.html.erb
index 5ff4b3bf0..6f7b1ec1a 100644
--- a/app/views/cards/taggings/new.html.erb
+++ b/app/views/cards/taggings/new.html.erb
@@ -1,7 +1,6 @@
 <%= turbo_frame_tag @card, :tagging do %>
-  <dialog class="popup panel flex-column align-start justify-start fill-white shadow txt-small"
+  <div class="flex-column"
     data-controller="filter navigable-list"
-    data-dialog-target="dialog filter navigable-list"
     data-navigable-list-focus-on-selection-value="false"
     data-navigable-list-actionable-items-value="true"
     data-action="keydown->navigable-list#navigate filter:changed->navigable-list#reset"
@@ -25,5 +24,5 @@
         </li>
       <% end %>
     </ul>
-  </dialog>
+  </div>
 <% end %>