From 7fe87bfce55c1c0947cd77f0a5504c847c037a19 Mon Sep 17 00:00:00 2001
From: David Heinemeier Hansson <david@37signals.com>
Date: Sun, 6 Apr 2025 13:47:27 +0200
Subject: [PATCH] This neednt be a turbo frame

Just because we are targeting something with a stream update does not
mean it needs to be a frame. The frame is only necessary when there is
lazy loading or we are creating a closed update loop.
---
 app/views/bubbles/cards/perma/_tags.html.erb | 42 ++++++++++----------
 1 file changed, 20 insertions(+), 22 deletions(-)

diff --git a/app/views/bubbles/cards/perma/_tags.html.erb b/app/views/bubbles/cards/perma/_tags.html.erb
index 1114ec300..3f670a61f 100644
--- a/app/views/bubbles/cards/perma/_tags.html.erb
+++ b/app/views/bubbles/cards/perma/_tags.html.erb
@@ -1,24 +1,22 @@
-<%= turbo_frame_tag bubble, :tags do %>
-  <div class="card__tags flex align-center flex-item-grow min-width">
-    <div class="overflow-ellipsis">
-      <% if bubble.tags.any? || bubble.creating? %>
-        <span># </span>
-        <% bubble.tags.each_with_index do |tag, index| %>
-          <%= link_to bubbles_path(bucket_ids: [ bubble.bucket ], tag_ids: [ tag.id ]),
-                      class: "card__tag btn btn--plain min-width txt-uppercase fill-transparent", data: { turbo_frame: "_top" } do %>
-            <span class="overflow-ellipsis"><%= tag.title %></span>
-          <% end %><%= ", " unless index == bubble.tags.size - 1 %>
-        <% end %>
+<div id="<%= dom_id(bubble, :tags) %>" class="card__tags flex align-center flex-item-grow min-width">
+  <div class="overflow-ellipsis">
+    <% if bubble.tags.any? || bubble.creating? %>
+      <span># </span>
+      <% bubble.tags.each_with_index do |tag, index| %>
+        <%= link_to bubbles_path(bucket_ids: [ bubble.bucket ], tag_ids: [ tag.id ]),
+          class: "card__tag btn btn--plain min-width txt-uppercase fill-transparent", data: { turbo_frame: "_top" } do %>
+          <span class="overflow-ellipsis"><%= tag.title %></span>
+        <% end %><%= ", " unless index == bubble.tags.size - 1 %>
+      <% end %>
     <% end %>
-    </div>
-
-    <div class="position-relative" data-controller="dialog" data-action="keydown.esc->dialog#close click@document->dialog#closeOnClickOutside">
-      <button class="tag-picker__button btn card__hide-on-index <%= bubble.creating? || bubble.drafted? ? "fill-highlight" : "fill-transparent" %>" data-action="click->dialog#open:stop">
-        <%= icon_tag "tag" %>
-        <span class="for-screen-reader">Add a tag</span>
-      </button>
-
-      <%= turbo_frame_tag bubble, :tagging, src: new_bubble_tagging_path(bubble) %>
-    </div>
   </div>
-<% end %>
+
+  <div class="position-relative" data-controller="dialog" data-action="keydown.esc->dialog#close click@document->dialog#closeOnClickOutside">
+    <button class="tag-picker__button btn card__hide-on-index <%= bubble.creating? || bubble.drafted? ? "fill-highlight" : "fill-transparent" %>" data-action="click->dialog#open:stop">
+      <%= icon_tag "tag" %>
+      <span class="for-screen-reader">Add a tag</span>
+    </button>
+
+    <%= turbo_frame_tag bubble, :tagging, src: new_bubble_tagging_path(bubble) %>
+  </div>
+</div>