From af5c06d00b4f95c831862d49a56d83281e1a3cf5 Mon Sep 17 00:00:00 2001 From: Andy Smith Date: Wed, 15 Oct 2025 13:26:51 -0500 Subject: [PATCH 01/34] Truncate long column names --- app/assets/stylesheets/card-columns.css | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/app/assets/stylesheets/card-columns.css b/app/assets/stylesheets/card-columns.css index 324c02997..2ed961d7b 100644 --- a/app/assets/stylesheets/card-columns.css +++ b/app/assets/stylesheets/card-columns.css @@ -268,15 +268,17 @@ font-weight: inherit; font-size: inherit; line-height: var(--column-width-collapsed); + overflow: hidden; + text-overflow: ellipsis; + white-space: nowrap; .cards.is-collapsed & { + max-inline-size: 50vh; writing-mode: vertical-rl; } .cards:not(.is-collapsed, .cards--considering) & { - overflow: hidden; - text-overflow: ellipsis; - white-space: nowrap; + max-inline-size: calc(100% - var(--column-width-collapsed) * 2); } } From 2568c8426872ee4adcf6888ed1b7c151e9a29c78 Mon Sep 17 00:00:00 2001 From: Andy Smith Date: Wed, 15 Oct 2025 13:35:59 -0500 Subject: [PATCH 02/34] Wrap collection filters when a bunch are added --- app/views/events/index/_filter.html.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/events/index/_filter.html.erb b/app/views/events/index/_filter.html.erb index f48ee4a6c..22572b40a 100644 --- a/app/views/events/index/_filter.html.erb +++ b/app/views/events/index/_filter.html.erb @@ -10,7 +10,7 @@ filter_show: user_filtering.show_collections?, multi_selection_combobox_no_selection_label_value: user_filtering.selected_collections_label } do %> From 963f0dab15bb93bece8fad39e744d90192d67ea3 Mon Sep 17 00:00:00 2001 From: Andy Smith Date: Wed, 15 Oct 2025 13:42:47 -0500 Subject: [PATCH 03/34] Aria labels for preview card meta icons --- app/views/cards/display/preview/_meta.html.erb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/views/cards/display/preview/_meta.html.erb b/app/views/cards/display/preview/_meta.html.erb index c385caf72..8ba8e04d8 100644 --- a/app/views/cards/display/preview/_meta.html.erb +++ b/app/views/cards/display/preview/_meta.html.erb @@ -13,12 +13,12 @@ - <%= icon_tag "refresh--meta" %> + <%= icon_tag "refresh--meta", aria: { label: "Last updated" } %> <%= local_datetime_tag(card.last_active_at, style: :daysago) %> - <%= icon_tag "arrow-right" if card.assignees.any? %> + <%= icon_tag("arrow-right", aria: { label: "Assigned to" }) if card.assignees.any? %> <%= card.assignees.map { |assignee| h assignee.familiar_name }.to_sentence(two_words_connector: " / ", last_word_connector: " / ").html_safe %> From fad74c128289fd45d83242294bcdbe7b6d5cb737 Mon Sep 17 00:00:00 2001 From: Andy Smith Date: Wed, 15 Oct 2025 13:45:51 -0500 Subject: [PATCH 04/34] Add screen reader labels for card ID --- app/views/cards/display/_public_preview.html.erb | 5 ++++- app/views/cards/display/common/_collection.html.erb | 5 ++++- app/views/events/event/_layout.html.erb | 5 ++++- app/views/notifications/notification/event/_header.html.erb | 5 ++++- .../notifications/notification/mention/_header.html.erb | 5 ++++- 5 files changed, 20 insertions(+), 5 deletions(-) diff --git a/app/views/cards/display/_public_preview.html.erb b/app/views/cards/display/_public_preview.html.erb index 644cb49d4..5494815e0 100644 --- a/app/views/cards/display/_public_preview.html.erb +++ b/app/views/cards/display/_public_preview.html.erb @@ -3,7 +3,10 @@
- <%= card.id %> + + Card number + <%= card.id %> + <%= card.collection.name %> diff --git a/app/views/cards/display/common/_collection.html.erb b/app/views/cards/display/common/_collection.html.erb index 9a69481c9..ef1fe3a5e 100644 --- a/app/views/cards/display/common/_collection.html.erb +++ b/app/views/cards/display/common/_collection.html.erb @@ -1,5 +1,8 @@