From 86e6309735e6e09b396328e28fbe89a1470c0a1d Mon Sep 17 00:00:00 2001
From: Jason Zimdars <jz@37signals.com>
Date: Wed, 2 Jul 2025 15:57:30 -0500
Subject: [PATCH] Hide dialog targets from screen readers when closed

---
 app/javascript/controllers/dialog_controller.js | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/app/javascript/controllers/dialog_controller.js b/app/javascript/controllers/dialog_controller.js
index fd4d122e0..123c2384e 100644
--- a/app/javascript/controllers/dialog_controller.js
+++ b/app/javascript/controllers/dialog_controller.js
@@ -6,6 +6,10 @@ export default class extends Controller {
     modal: { type: Boolean, default: false }
   }
 
+  connect() {
+    this.dialogTarget.setAttribute('aria-hidden', 'true')
+  }
+
   open() {
     const modal = this.modalValue
 
@@ -14,6 +18,7 @@ export default class extends Controller {
     } else {
       this.dialogTarget.show()
     }
+    this.dialogTarget.setAttribute('aria-hidden', 'false')
   }
 
   toggle() {
@@ -26,6 +31,7 @@ export default class extends Controller {
 
   close() {
     this.dialogTarget.close()
+    this.dialogTarget.setAttribute('aria-hidden', 'true')
     this.dialogTarget.blur()
   }