From 87c2428d479e7b8b0b671e7eb6d31011b4dc141e Mon Sep 17 00:00:00 2001
From: Jason Zimdars <jz@37signals.com>
Date: Thu, 20 Nov 2025 16:02:03 -0600
Subject: [PATCH] Differentiate, even though they share some properties

---
 app/assets/stylesheets/card-columns.css        | 12 +++++++++---
 app/views/boards/show/_closed.html.erb         |  2 +-
 app/views/boards/show/_mobile_columns.html.erb |  2 +-
 app/views/public/boards/show/_closed.html.erb  |  2 +-
 4 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/app/assets/stylesheets/card-columns.css b/app/assets/stylesheets/card-columns.css
index 5fda5823b..2170b576e 100644
--- a/app/assets/stylesheets/card-columns.css
+++ b/app/assets/stylesheets/card-columns.css
@@ -438,9 +438,7 @@
 
     /* Cover bubbles and cards on small viewports */
     @media (max-width: 639px) {
-      &:not(.cards--closed &) {
-        margin-inline: calc(-1 * var(--cards-gap) - var(--main-padding));
-      }
+      margin-inline: calc(-1 * var(--cards-gap) - var(--main-padding));
     }
 
     &, .cards__filter {
@@ -659,6 +657,7 @@
   /* On Deck (Not Now)
   /* ------------------------------------------------------------------------ */
 
+  .cards--closed,
   .cards--on-deck {
     --card-color: var(--color-ink-light) !important;
 
@@ -671,6 +670,13 @@
     }
   }
 
+  /* Closed (Done)
+  /* ------------------------------------------------------------------------ */
+
+  .cards--closed {
+
+  }
+
   /* Doing
   /* -------------------------------------------------------------------------- */
 
diff --git a/app/views/boards/show/_closed.html.erb b/app/views/boards/show/_closed.html.erb
index 0d4c772f4..5d2820399 100644
--- a/app/views/boards/show/_closed.html.erb
+++ b/app/views/boards/show/_closed.html.erb
@@ -1,4 +1,4 @@
-<%= column_tag id: "closed-cards", name: "Done", drop_url: columns_card_drops_closure_path("__id__"), class: "cards--on-deck", style: "--card-color: var(--color-card-complete);",
+<%= column_tag id: "closed-cards", name: "Done", drop_url: columns_card_drops_closure_path("__id__"), class: "cards--closed", style: "--card-color: var(--color-card-complete);",
   data: {
     drag_and_strum_target: "container",
     collapsible_columns_target: "column",
diff --git a/app/views/boards/show/_mobile_columns.html.erb b/app/views/boards/show/_mobile_columns.html.erb
index 0848b2cea..964d75220 100644
--- a/app/views/boards/show/_mobile_columns.html.erb
+++ b/app/views/boards/show/_mobile_columns.html.erb
@@ -32,7 +32,7 @@
     <% end %>
   <% end %>
 
-  <%= link_to board_columns_closed_path(board), class: "cards cards--on-deck is-collapsed", style: "--card-color: var(--color-card-complete);", data: { turbo_frame: "_top" } do %>
+  <%= link_to board_columns_closed_path(board), class: "cards cards--closed is-collapsed", style: "--card-color: var(--color-card-complete);", data: { turbo_frame: "_top" } do %>
     <div class="cards__expander btn btn--plain" style="--card-count: <%= board.cards.closed.count %>">
       <span class="cards__expander-count"><%= board.cards.closed.count %></span>
       <h2 class="cards__expander-title">
diff --git a/app/views/public/boards/show/_closed.html.erb b/app/views/public/boards/show/_closed.html.erb
index 9f1e1c930..ec75aed00 100644
--- a/app/views/public/boards/show/_closed.html.erb
+++ b/app/views/public/boards/show/_closed.html.erb
@@ -1,4 +1,4 @@
-<section id="closed-cards" class="cards cards--on-deck is-collapsed" style="--card-color: var(--color-card-complete);"
+<section id="closed-cards" class="cards cards--closed is-collapsed" style="--card-color: var(--color-card-complete);"
   data-collapsible-columns-target="column"
   data-action="turbo:before-morph-attribute->collapsible-columns#preventToggle"
 >