From 8c4d3fd70096ea99839bef12a0349ef7d46144d0 Mon Sep 17 00:00:00 2001 From: Jason Zimdars Date: Thu, 30 Oct 2025 17:11:22 -0500 Subject: [PATCH 1/2] Don't try to orient these We need to figure out how to handle the assignment popup when it's close to the bottom of the screen but this isn't doing it --- app/assets/stylesheets/popup.css | 8 -------- app/javascript/helpers/orientation_helpers.js | 7 +------ 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/app/assets/stylesheets/popup.css b/app/assets/stylesheets/popup.css index 852787701..41c6420b3 100644 --- a/app/assets/stylesheets/popup.css +++ b/app/assets/stylesheets/popup.css @@ -29,14 +29,6 @@ transform: translateX(0); } - &.orient-top { - inset-block: auto 0; - - &.orient-bottom { - inset-block: 0 auto; - } - } - &:has(.popup__footer) { --panel-padding: var(--block-space) var(--block-space) 0 var(--block-space); } diff --git a/app/javascript/helpers/orientation_helpers.js b/app/javascript/helpers/orientation_helpers.js index 672275778..4e3f1a3a5 100644 --- a/app/javascript/helpers/orientation_helpers.js +++ b/app/javascript/helpers/orientation_helpers.js @@ -4,8 +4,7 @@ export function orient(el, orient = true) { const directions = [ ["orient-left", spaceOnRight], ["orient-right", spaceOnLeft], - ["orient-top", spaceOnBottom], - ["orient-bottom", spaceOnTop] + ["orient-top", spaceOnBottom] ]; directions.forEach(([className, fn]) => @@ -24,7 +23,3 @@ function spaceOnRight(el) { function spaceOnBottom(el) { return window.innerHeight - el.getBoundingClientRect().bottom } - -function spaceOnTop(el) { - return el.getBoundingClientRect().top -} From 07d74d987d7ee81a5dfe110f39014cf5f5a619fd Mon Sep 17 00:00:00 2001 From: Jason Zimdars Date: Thu, 30 Oct 2025 17:21:06 -0500 Subject: [PATCH 2/2] Typo --- app/views/bar/_bar.html.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/views/bar/_bar.html.erb b/app/views/bar/_bar.html.erb index d20bd10a1..a0abb1d28 100644 --- a/app/views/bar/_bar.html.erb +++ b/app/views/bar/_bar.html.erb @@ -1,4 +1,4 @@ -
<%= tag.button class: "btn btn--plain", data: {