From 8ca9e80c6c2b7947cf1e3aed60da6502ea92f868 Mon Sep 17 00:00:00 2001 From: Jason Zimdars Date: Fri, 17 Oct 2025 16:56:26 -0500 Subject: [PATCH] Settle on "Moved to Done" --- app/helpers/events_helper.rb | 2 +- app/helpers/notifications_helper.rb | 2 +- app/helpers/webhooks_helper.rb | 2 +- app/models/card/eventable/system_commenter.rb | 2 +- app/models/notification_pusher.rb | 2 +- test/models/card/eventable/system_commenter_test.rb | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/app/helpers/events_helper.rb b/app/helpers/events_helper.rb index 7e0ae61cf..fe8116ebd 100644 --- a/app/helpers/events_helper.rb +++ b/app/helpers/events_helper.rb @@ -84,7 +84,7 @@ module EventsHelper when "card_published" "#{h event_creator_name(event) } added \"#{h title }\"".html_safe when "card_closed" - "#{h event_creator_name(event) } marked \"#{h title }\" as done".html_safe + "#{h event_creator_name(event) } moved \"#{h title }\" to done".html_safe when "card_reopened" "#{h event_creator_name(event) } reopened \"#{h title }\"".html_safe when "card_due_date_added" diff --git a/app/helpers/notifications_helper.rb b/app/helpers/notifications_helper.rb index 2f0456f78..5dfad5225 100644 --- a/app/helpers/notifications_helper.rb +++ b/app/helpers/notifications_helper.rb @@ -10,7 +10,7 @@ module NotificationsHelper name = event.creator.name case event_notification_action(event) - when "card_closed" then "Marked as “Done” by #{name}" + when "card_closed" then "Moved to Done by #{name}" when "card_reopened" then "Reopened by #{name}" when "card_published" then "Added by #{name}" when "comment_created" then comment_notification_body(event) diff --git a/app/helpers/webhooks_helper.rb b/app/helpers/webhooks_helper.rb index 42c12c404..b3e14c4ab 100644 --- a/app/helpers/webhooks_helper.rb +++ b/app/helpers/webhooks_helper.rb @@ -1,7 +1,7 @@ module WebhooksHelper ACTION_LABELS = { card_assigned: "Card assigned", - card_closed: "Card marked as Done", + card_closed: "Card moved to Done", card_collection_changed: "Card collection changed", card_due_date_added: "Card due date added", card_due_date_changed: "Card due date changed", diff --git a/app/models/card/eventable/system_commenter.rb b/app/models/card/eventable/system_commenter.rb index 29f981173..5c1e53b16 100644 --- a/app/models/card/eventable/system_commenter.rb +++ b/app/models/card/eventable/system_commenter.rb @@ -19,7 +19,7 @@ class Card::Eventable::SystemCommenter when "card_unassigned" "#{event.creator.name} unassigned from #{event.assignees.pluck(:name).to_sentence}." when "card_closed" - "Marked as “Done” by #{ event.creator.name }" + "Moved to Done by #{ event.creator.name }" when "card_reopened" "Reopened by #{ event.creator.name }" when "card_title_changed" diff --git a/app/models/notification_pusher.rb b/app/models/notification_pusher.rb index 65449b0a8..0938954b0 100644 --- a/app/models/notification_pusher.rb +++ b/app/models/notification_pusher.rb @@ -60,7 +60,7 @@ class NotificationPusher ) when "card_closed" base_payload.merge( - body: card.closure ? "Marked as “Done” by #{event.creator.name}" : "Closed by #{event.creator.name}" + body: card.closure ? "Moved to Done by #{event.creator.name}" : "Closed by #{event.creator.name}" ) when "card_reopened" base_payload.merge( diff --git a/test/models/card/eventable/system_commenter_test.rb b/test/models/card/eventable/system_commenter_test.rb index 2008c031c..e07c9474f 100644 --- a/test/models/card/eventable/system_commenter_test.rb +++ b/test/models/card/eventable/system_commenter_test.rb @@ -22,7 +22,7 @@ class Card::Eventable::SystemCommenterTest < ActiveSupport::TestCase end test "card_closed" do - assert_system_comment "Marked as “Done” by David" do + assert_system_comment "Moved to Done by David" do @card.close end end