From 939d68b9414abfb9db02d29bc88603f782d4d8a0 Mon Sep 17 00:00:00 2001 From: Jorge Manrubia Date: Tue, 1 Jul 2025 11:38:44 +0200 Subject: [PATCH] Don't prevent default with light/right arrows since this prevents moving cursor on input fields --- app/javascript/controllers/navigable_list_controller.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/javascript/controllers/navigable_list_controller.js b/app/javascript/controllers/navigable_list_controller.js index eb416c159..6347e9fde 100644 --- a/app/javascript/controllers/navigable_list_controller.js +++ b/app/javascript/controllers/navigable_list_controller.js @@ -86,10 +86,10 @@ export default class extends Controller { } } - #handleArrowKey(event, fn) { + #handleArrowKey(event, fn, preventDefault = true) { if (event.shiftKey || event.metaKey || event.ctrlKey) { return } fn.call() - event.preventDefault() + if (preventDefault) { event.preventDefault() } } #clickCurrentItem(event) { @@ -119,10 +119,10 @@ export default class extends Controller { this.#handleArrowKey(event, this.#selectPrevious.bind(this)) }, ArrowRight(event) { - this.#handleArrowKey(event, this.#selectNext.bind(this)) + this.#handleArrowKey(event, this.#selectNext.bind(this), false) }, ArrowLeft(event) { - this.#handleArrowKey(event, this.#selectPrevious.bind(this)) + this.#handleArrowKey(event, this.#selectPrevious.bind(this), false) }, Enter(event) { if (event.shiftKey) {