From 31f2e941b25efa394463480a0443f7e50bbabbc2 Mon Sep 17 00:00:00 2001 From: Jason Zimdars Date: Mon, 6 Oct 2025 09:27:56 -0500 Subject: [PATCH 1/8] Fix that background effect overlapped the pagination buttons --- app/assets/stylesheets/card-columns.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/stylesheets/card-columns.css b/app/assets/stylesheets/card-columns.css index be049c19c..5ce002828 100644 --- a/app/assets/stylesheets/card-columns.css +++ b/app/assets/stylesheets/card-columns.css @@ -461,7 +461,7 @@ inset: calc(var(--column-width-collapsed) + var(--block-space-half)) 0 0 0; mask: var(--wavy-background-mask); position: absolute; - z-index: 0; + z-index: -1; } } From f2abbb5d59f919c3b084642c173438177146e27c Mon Sep 17 00:00:00 2001 From: Jason Zimdars Date: Mon, 6 Oct 2025 13:10:19 -0500 Subject: [PATCH 2/8] Display email address for users Helps identify invited people --- app/views/account/_user.html.erb | 5 ++++- app/views/collections/_access_toggle.erb | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/app/views/account/_user.html.erb b/app/views/account/_user.html.erb index add56b38f..78395ff1c 100644 --- a/app/views/account/_user.html.erb +++ b/app/views/account/_user.html.erb @@ -1,7 +1,10 @@
  • <%= link_to user, class: "txt-ink flex gap-half align-center min-width" do %> <%= avatar_preview_tag user, hidden_for_screen_reader: true %> - <%= user.name %> +
    + <%= user.name %> +
    <%= user.email_address %>
    +
    <% end %> diff --git a/app/views/collections/_access_toggle.erb b/app/views/collections/_access_toggle.erb index 9940d6b14..824cace65 100644 --- a/app/views/collections/_access_toggle.erb +++ b/app/views/collections/_access_toggle.erb @@ -1,7 +1,10 @@
  • <%= link_to user, class: "txt-ink flex gap-half align-center min-width" do %> <%= avatar_preview_tag user, hidden_for_screen_reader: true %> - <%= user.name %> +
    + <%= user.name %> +
    <%= user.email_address %>
    +
    <% end %> From 37c20caf98f273d4bf4b02eb8632921d1c47687a Mon Sep 17 00:00:00 2001 From: Jason Zimdars Date: Mon, 6 Oct 2025 13:24:52 -0500 Subject: [PATCH 3/8] Tighten up, remove keyboard nav hint You'll only rarely need to use this, no need to explain a feature most people don't need --- app/assets/stylesheets/settings.css | 4 ++-- app/views/account/settings/_users.html.erb | 8 ++------ app/views/collections/edit/_users.html.erb | 2 +- 3 files changed, 5 insertions(+), 9 deletions(-) diff --git a/app/assets/stylesheets/settings.css b/app/assets/stylesheets/settings.css index afc3beed8..a1c37e88d 100644 --- a/app/assets/stylesheets/settings.css +++ b/app/assets/stylesheets/settings.css @@ -19,7 +19,7 @@ display: flex; flex-direction: column; - gap: var(--settings-spacer); + gap: calc(var(--settings-spacer) / 2); min-block-size: 100%; min-inline-size: 0; @@ -45,7 +45,7 @@ display: flex; flex-direction: column; - gap: var(--settings-spacer); + gap: calc(var(--settings-spacer) / 4); min-height: 0; } diff --git a/app/views/account/settings/_users.html.erb b/app/views/account/settings/_users.html.erb index cbcbaee50..61449f09a 100644 --- a/app/views/account/settings/_users.html.erb +++ b/app/views/account/settings/_users.html.erb @@ -8,14 +8,10 @@ <%#= render "account/invite" # Scheduled work in https://3.basecamp.com/2914079/buckets/37331921/todos/8746162337 %>
    - + -
      +
        <%= render partial: "account/user", collection: users %>
      - -
      - Press ↑↓ to move, enter to visit profile, SHIFT+ENTER to toggle. -
    <% end %> diff --git a/app/views/collections/edit/_users.html.erb b/app/views/collections/edit/_users.html.erb index ea518b681..6e12f5016 100644 --- a/app/views/collections/edit/_users.html.erb +++ b/app/views/collections/edit/_users.html.erb @@ -18,7 +18,7 @@
    • - +
    From ae3a3b99da62922f17a171eaf72ba00c32eef9fe Mon Sep 17 00:00:00 2001 From: Jason Zimdars Date: Mon, 6 Oct 2025 13:26:26 -0500 Subject: [PATCH 4/8] A little more space for Windows --- app/assets/stylesheets/filters.css | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/assets/stylesheets/filters.css b/app/assets/stylesheets/filters.css index b911649da..5999d2598 100644 --- a/app/assets/stylesheets/filters.css +++ b/app/assets/stylesheets/filters.css @@ -108,8 +108,8 @@ --input-border-radius: 5em; --input-padding: 0.5em 2.3em 0.5em 1.3em; - inline-size: 22ch; - min-inline-size: 22ch; + inline-size: 25ch; + min-inline-size: 25ch; .filters:not(.filters--expanded, .filters--has-filters-set) & { margin-inline-end: calc((var(--btn-size) + var(--inline-space-half) + 0.25em) * -1); From 0ff0ed796f5ed7719fd70789123bcc666cd5799a Mon Sep 17 00:00:00 2001 From: Jason Zimdars Date: Mon, 6 Oct 2025 13:29:31 -0500 Subject: [PATCH 5/8] Fix that pins were still hoverable and clickable when hidden --- app/assets/stylesheets/trays.css | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/assets/stylesheets/trays.css b/app/assets/stylesheets/trays.css index b024a0412..f36927d1c 100644 --- a/app/assets/stylesheets/trays.css +++ b/app/assets/stylesheets/trays.css @@ -383,11 +383,13 @@ background-color: var(--card-bg-color); inset: 0 0 auto auto; opacity: 0; + pointer-events: none; position: absolute; z-index: 1; .tray__dialog[open] & { opacity: 0.66; + pointer-events: unset; &:hover { opacity: 1; From bfb60deb8046534d0eb2d9ed5699cd28b41cc47b Mon Sep 17 00:00:00 2001 From: Jason Zimdars Date: Mon, 6 Oct 2025 13:34:18 -0500 Subject: [PATCH 6/8] Fix display of button in varying conditions --- app/helpers/pagination_helper.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/helpers/pagination_helper.rb b/app/helpers/pagination_helper.rb index 6c67400c7..4a1603e6a 100644 --- a/app/helpers/pagination_helper.rb +++ b/app/helpers/pagination_helper.rb @@ -5,7 +5,7 @@ module PaginationHelper def link_to_next_page(namespace, page, activate_when_observed: false, label: "Load more...", data: {}, **attributes) if page.before_last? && !params[:previous] - pagination_link(namespace, page.number + 1, label: label, activate_when_observed: activate_when_observed, data: data, class: "margin-block btn txt-small center", **attributes) + pagination_link(namespace, page.number + 1, label: label, activate_when_observed: activate_when_observed, data: data, class: "btn txt-small center-block center", **attributes) end end From e077edc17a4fe1272202d72198e8d359ac92ae2d Mon Sep 17 00:00:00 2001 From: Jason Zimdars Date: Mon, 6 Oct 2025 13:55:22 -0500 Subject: [PATCH 7/8] We need this for mobile rendering --- app/assets/stylesheets/bar.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/stylesheets/bar.css b/app/assets/stylesheets/bar.css index 29889ef38..23376ce97 100644 --- a/app/assets/stylesheets/bar.css +++ b/app/assets/stylesheets/bar.css @@ -10,7 +10,7 @@ font-size: 0.9em; inset: auto 0 0 0; max-block-size: 100%; - padding: 0 calc(var(--tray-size) + calc(var(--inline-space) * 3)) env(safe-area-inset-bottom); + padding: var(--block-space) calc(var(--tray-size) + calc(var(--inline-space) * 3)) calc(var(--block-space) + env(safe-area-inset-bottom)); place-content: center; position: fixed; z-index: var(--z-terminal); From 609f6cfe6af44dfbb895c69cfe697403d56b6535 Mon Sep 17 00:00:00 2001 From: Jason Zimdars Date: Mon, 6 Oct 2025 14:01:36 -0500 Subject: [PATCH 8/8] Ensure you can click through to results below the header --- app/assets/stylesheets/search.css | 1 + 1 file changed, 1 insertion(+) diff --git a/app/assets/stylesheets/search.css b/app/assets/stylesheets/search.css index 371ed21fd..bf6b44c07 100644 --- a/app/assets/stylesheets/search.css +++ b/app/assets/stylesheets/search.css @@ -69,6 +69,7 @@ summary { inset: 0 0 auto 0; justify-content: flex-end; padding: var(--block-space-half) var(--block-space); + pointer-events: none; position: absolute; }