bterkuile/fizzy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove ActionText::Attachable from Tag

Browse Source 
Tag was never actually embedded as an action-text-attachment in
persisted rich text. It was only used in the Fizzy Do command prompt
input which was not stored. The data transfer tests happened to use Tag
as a convenient fixture — switch them to User, which is genuinely
attachable via mentions.
This commit is contained in:
Mike Dalessio
2026-04-09 17:17:29 -04:00
parent 151787a864
commit 975b8998ef
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/models/tag.rb
+1 -1
View File
@@ -1,5 +1,5 @@
class Tag < ApplicationRecord class Tag < ApplicationRecord
include ActionText::Attachable, Filterable include Filterable
belongs_to :account, default: -> { Current.account } belongs_to :account, default: -> { Current.account }
has_many :taggings, dependent: :destroy has_many :taggings, dependent: :destroy
test/models/account/data_transfer/action_text/rich_text_record_set_test.rb
+7 -7
View File
@@ -44,11 +44,11 @@ class Account::DataTransfer::ActionText::RichTextRecordSetTest < ActiveSupport::
end end
test "transform_body_for_import skips GIDs belonging to another account" do test "transform_body_for_import skips GIDs belonging to another account" do
victim_tag = tags(:web) victim_user = users(:david)
attacker_account = accounts(:initech) attacker_account = accounts(:initech)
assert_not_equal attacker_account.id, victim_tag.account_id assert_not_equal attacker_account.id, victim_user.account_id
cross_tenant_gid = victim_tag.to_global_id.to_s cross_tenant_gid = victim_user.to_global_id.to_s
html = %(<action-text-attachment gid="#{cross_tenant_gid}"></action-text-attachment>) html = %(<action-text-attachment gid="#{cross_tenant_gid}"></action-text-attachment>)
record_set = Account::DataTransfer::ActionText::RichTextRecordSet.new(attacker_account) record_set = Account::DataTransfer::ActionText::RichTextRecordSet.new(attacker_account)
@@ -59,11 +59,11 @@ class Account::DataTransfer::ActionText::RichTextRecordSetTest < ActiveSupport::
end end
test "transform_body_for_import converts GIDs belonging to the same account" do test "transform_body_for_import converts GIDs belonging to the same account" do
own_tag = tags(:web) own_user = users(:david)
own_account = accounts(:"37s") own_account = accounts(:"37s")
assert_equal own_account.id, own_tag.account_id assert_equal own_account.id, own_user.account_id
same_account_gid = own_tag.to_global_id.to_s same_account_gid = own_user.to_global_id.to_s
html = %(<action-text-attachment gid="#{same_account_gid}"></action-text-attachment>) html = %(<action-text-attachment gid="#{same_account_gid}"></action-text-attachment>)
record_set = Account::DataTransfer::ActionText::RichTextRecordSet.new(own_account) record_set = Account::DataTransfer::ActionText::RichTextRecordSet.new(own_account)
@@ -74,7 +74,7 @@ class Account::DataTransfer::ActionText::RichTextRecordSetTest < ActiveSupport::
end end
test "transform_body_for_import handles non-existent record GIDs gracefully" do test "transform_body_for_import handles non-existent record GIDs gracefully" do
nonexistent_gid = "gid://fizzy/Tag/00000000000000000000000000" nonexistent_gid = "gid://fizzy/User/00000000000000000000000000"
html = %(<action-text-attachment gid="#{nonexistent_gid}"></action-text-attachment>) html = %(<action-text-attachment gid="#{nonexistent_gid}"></action-text-attachment>)
record_set = Account::DataTransfer::ActionText::RichTextRecordSet.new(accounts(:"37s")) record_set = Account::DataTransfer::ActionText::RichTextRecordSet.new(accounts(:"37s"))