Forbid comments on draft cards

- Add Card#commentable? method that returns true only for published cards.
- CardsController#create ensures that the card is commentable.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Mike Dalessio
2026-01-23 11:28:15 -05:00
parent bb2d3a59b5
commit 9aa15e9fb2
7 changed files with 47 additions and 10 deletions
+13
View File
@@ -5,6 +5,19 @@ class CommentTest < ActiveSupport::TestCase
Current.session = sessions(:david)
end
test "cannot create comment on a draft card" do
draft_card = cards(:unfinished_thoughts)
comment = draft_card.comments.build(body: "This should fail")
assert_not comment.valid?
assert_includes comment.errors[:card], "does not allow comments"
assert_raises(ActiveRecord::RecordInvalid) do
draft_card.comments.create!(body: "This should raise")
end
end
test "rich text embed variants are processed immediately on attachment" do
comment = cards(:logo).comments.create!(body: "Check this out")
comment.body.body.attachables # force load