From a49c6dc3f606be4b2ccd957d1947dace46d34fcf Mon Sep 17 00:00:00 2001
From: Jose Farias <jose@37signals.com>
Date: Thu, 24 Oct 2024 10:51:23 -0600
Subject: [PATCH] Refactor `Bubble#toggle_stage`

---
 app/models/bubble/staged.rb | 15 +++++----------
 1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/app/models/bubble/staged.rb b/app/models/bubble/staged.rb
index 993464754..ab715bd07 100644
--- a/app/models/bubble/staged.rb
+++ b/app/models/bubble/staged.rb
@@ -10,16 +10,11 @@ module Bubble::Staged
   end
 
   def toggle_stage(stage)
-    if self.stage_id == stage.id
-      transaction do
-        update! stage: nil
-        track_event :unstaged, stage_name: stage.name
-      end
-    else
-      transaction do
-        update! stage: stage
-        track_event :staged, stage_name: stage.name
-      end
+    new_stage, event = self.stage_id == stage.id ? [ nil, :unstaged ] : [ stage, :staged ]
+
+    transaction do
+      update! stage: new_stage
+      track_event event, stage_name: stage.name
     end
   end
 end