From aa7a92c448154773380a33f79bf423a577161ae0 Mon Sep 17 00:00:00 2001
From: Jorge Manrubia <jorge@37signals.com>
Date: Thu, 15 May 2025 16:07:51 +0200
Subject: [PATCH] Move terminal output outside of the frame so that it doesn't
 gets erased when reloading the frame

---
 app/javascript/controllers/terminal_controller.js | 1 +
 app/views/commands/_terminal.html.erb             | 1 +
 app/views/commands/index.html.erb                 | 1 -
 3 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/app/javascript/controllers/terminal_controller.js b/app/javascript/controllers/terminal_controller.js
index 8d3c2235f..dd29b96c0 100644
--- a/app/javascript/controllers/terminal_controller.js
+++ b/app/javascript/controllers/terminal_controller.js
@@ -164,6 +164,7 @@ export default class extends Controller {
 
   #showOutput(html) {
     this.element.classList.add(this.outputClass)
+    console.debug("PUT ON ", this.outputTarget);
     this.outputTarget.innerHTML = html
   }
 
diff --git a/app/views/commands/_terminal.html.erb b/app/views/commands/_terminal.html.erb
index aeb922d2e..14688463a 100644
--- a/app/views/commands/_terminal.html.erb
+++ b/app/views/commands/_terminal.html.erb
@@ -11,6 +11,7 @@
         toggle_class_toggle_class: "terminal--open",
         action: "keydown->terminal#handleKeyPress keydown->navigable-list#navigate focusin->navigable-list#select keydown.esc->toggle-class#remove:stop keydown.esc->terminal#focus keydown.esc->navigable-list#selectLast keydown.esc@document->terminal#hideMenus" } do %>
   <%= turbo_frame_tag :recent_commands, src: commands_path, data: { terminal_target: "recentCommands" } %>
+  <div class="terminal--output" data-terminal-target="output"></div>
 
   <%= render "commands/form" %>
 <% end %>
diff --git a/app/views/commands/index.html.erb b/app/views/commands/index.html.erb
index ced1afc3e..3b14f3338 100644
--- a/app/views/commands/index.html.erb
+++ b/app/views/commands/index.html.erb
@@ -1,6 +1,5 @@
 <%= turbo_frame_tag :recent_commands do %>
   <ul class="terminal__menu flex-column txt-align-start margin-none margin-block-end unpad" aria-label="Recent commands"><%= render partial: "commands/command", collection: @commands %></ul>
 
-  <div class="terminal--output" data-terminal-target="output"></div>
   <%= render "commands/help" %>
 <% end %>