From ac0baed6637bbb416df93398a2d9e4771c8b4db6 Mon Sep 17 00:00:00 2001
From: Jorge Manrubia <jorge@37signals.com>
Date: Thu, 3 Apr 2025 14:44:04 +0200
Subject: [PATCH] Add some missing tests

---
 .../bubbles/engagements_controller_test.rb    | 27 +++++++++++++++++++
 test/models/filter_test.rb                    |  8 ++++++
 2 files changed, 35 insertions(+)
 create mode 100644 test/controllers/bubbles/engagements_controller_test.rb

diff --git a/test/controllers/bubbles/engagements_controller_test.rb b/test/controllers/bubbles/engagements_controller_test.rb
new file mode 100644
index 000000000..12a2a73b8
--- /dev/null
+++ b/test/controllers/bubbles/engagements_controller_test.rb
@@ -0,0 +1,27 @@
+require "test_helper"
+
+class Bubbles::EngagementsControllerTest < ActionDispatch::IntegrationTest
+  setup do
+    sign_in_as :kevin
+  end
+
+  test "create" do
+    bubble = bubbles(:shipping)
+
+    assert_changes -> { bubble.reload.doing? }, from: false, to: true do
+      post bucket_bubble_engagement_url(bubble.bucket, bubble)
+    end
+
+    assert_redirected_to bucket_bubble_url(bubble.bucket, bubble)
+  end
+
+  test "destroy" do
+    bubble = bubbles(:logo)
+
+    assert_changes -> { bubble.reload.doing? }, from: true, to: false do
+      delete bucket_bubble_engagement_url(bubble.bucket, bubble)
+    end
+
+    assert_redirected_to bucket_bubble_url(bubble.bucket, bubble)
+  end
+end
diff --git a/test/models/filter_test.rb b/test/models/filter_test.rb
index b5df283ad..6a7a1abfa 100644
--- a/test/models/filter_test.rb
+++ b/test/models/filter_test.rb
@@ -131,4 +131,12 @@ class FilterTest < ActiveSupport::TestCase
     expected = { indexed_by: "most_discussed", assignee_ids: [ users(:jz).id, users(:kevin).id ] }
     assert_equal expected, filter.as_params_without(:assignee_ids, users(:david).id).to_h
   end
+
+  test "get a clone with some changed params" do
+    seed_filter = users(:david).filters.new indexed_by: "active", terms: [ "haggis" ]
+    filter = seed_filter.with(indexed_by: "popped")
+
+    assert filter.indexed_by.popped?
+    assert_equal ["haggis"], filter.terms
+  end
 end