From b2e3c7b1c79bc974f70be719e3e063d56aa15e22 Mon Sep 17 00:00:00 2001 From: Mike Dalessio Date: Fri, 21 Nov 2025 10:49:41 -0500 Subject: [PATCH] Drop the "max previewable file size" limit which was originally introduced to work around timing issues causing us to try (and fail) to generate previews on sqlite read replicas. --- .../active_storage_blob_previewable.rb | 18 ------------------ .../active_storage_blob_previewable_test.rb | 13 ------------- 2 files changed, 31 deletions(-) delete mode 100644 lib/rails_ext/active_storage_blob_previewable.rb delete mode 100644 test/lib/rails_ext/active_storage_blob_previewable_test.rb diff --git a/lib/rails_ext/active_storage_blob_previewable.rb b/lib/rails_ext/active_storage_blob_previewable.rb deleted file mode 100644 index c3ceb31ae..000000000 --- a/lib/rails_ext/active_storage_blob_previewable.rb +++ /dev/null @@ -1,18 +0,0 @@ -# -# see https://app.fizzy.do/5986089/collections/7/cards/1302 -# -# Large previewable uploads may take longer than the "pin reads" interval. So we pick a small-ish -# number and turn off previews for anything larger, at least until we can come up with a permanent -# solution. -# -module ActiveStorageBlobPreviewable - MAX_PREVIEWABLE_SIZE = 16.megabytes # this is pretty arbitrary, feel free to adjust - - def previewable? - super && self.byte_size <= MAX_PREVIEWABLE_SIZE - end -end - -ActiveSupport.on_load :active_storage_blob do - prepend ::ActiveStorageBlobPreviewable -end diff --git a/test/lib/rails_ext/active_storage_blob_previewable_test.rb b/test/lib/rails_ext/active_storage_blob_previewable_test.rb deleted file mode 100644 index 290cc3cf9..000000000 --- a/test/lib/rails_ext/active_storage_blob_previewable_test.rb +++ /dev/null @@ -1,13 +0,0 @@ -require "test_helper" - -class ActiveStorageBlobPreviewableTest < ActiveSupport::TestCase - test "small files are previewable" do - blob = ActiveStorage::Blob.new(filename: "test.mp4", content_type: "video/mp4", byte_size: 1024 * 1024, key: "test", checksum: "abc") - assert blob.previewable? - end - - test "large files are not previewable" do - blob = ActiveStorage::Blob.new(filename: "test.mp4", content_type: "video/mp4", byte_size: ActiveStorageBlobPreviewable::MAX_PREVIEWABLE_SIZE + 1, key: "test", checksum: "abc") - assert_not blob.previewable? - end -end