From 2ecbe2cb7e3867d85afaf659967a9133b68ce1ec Mon Sep 17 00:00:00 2001 From: Andy Smith Date: Fri, 19 Sep 2025 16:19:37 -0500 Subject: [PATCH 1/2] Add option for icon-only involvement buttons --- app/helpers/accesses_helper.rb | 8 ++++---- app/views/notifications/settings/_collection.html.erb | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/helpers/accesses_helper.rb b/app/helpers/accesses_helper.rb index 0fb8e8f36..bb1f5b655 100644 --- a/app/helpers/accesses_helper.rb +++ b/app/helpers/accesses_helper.rb @@ -17,12 +17,12 @@ module AccessesHelper cached: ->(user) { [ user, selected ] } end - def access_involvement_advance_button(collection, user, show_watchers: true) + def access_involvement_advance_button(collection, user, show_watchers: true, icon_only: false) access = collection.access_for(user) turbo_frame_tag dom_id(collection, :involvement_button) do concat collection_watchers_list(collection) if show_watchers - concat involvement_button(collection, access, show_watchers) + concat involvement_button(collection, access, show_watchers, icon_only) end end @@ -43,7 +43,7 @@ module AccessesHelper end end - def involvement_button(collection, access, show_watchers) + def involvement_button(collection, access, show_watchers, icon_only) involvement_label_id = dom_id(collection, :involvement_label) button_to( @@ -57,7 +57,7 @@ module AccessesHelper icon_tag("notification-bell-#{access.involvement.dasherize}"), tag.span( involvement_access_label(collection, access.involvement), - class: "txt-nowrap txt-uppercase", + class: "txt-nowrap txt-uppercase#{icon_only ? ' for-screen-reader' : ''}", id: involvement_label_id ) ]) diff --git a/app/views/notifications/settings/_collection.html.erb b/app/views/notifications/settings/_collection.html.erb index 08aec6409..ad921dfd3 100644 --- a/app/views/notifications/settings/_collection.html.erb +++ b/app/views/notifications/settings/_collection.html.erb @@ -7,7 +7,7 @@ <% end %> From 7fec5a98c18f6b64522014b46b5ca65efddd1d63 Mon Sep 17 00:00:00 2001 From: Andy Smith Date: Mon, 22 Sep 2025 11:22:40 -0500 Subject: [PATCH 2/2] Use class_names helper --- app/helpers/accesses_helper.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/helpers/accesses_helper.rb b/app/helpers/accesses_helper.rb index bb1f5b655..833a1a2b0 100644 --- a/app/helpers/accesses_helper.rb +++ b/app/helpers/accesses_helper.rb @@ -57,7 +57,7 @@ module AccessesHelper icon_tag("notification-bell-#{access.involvement.dasherize}"), tag.span( involvement_access_label(collection, access.involvement), - class: "txt-nowrap txt-uppercase#{icon_only ? ' for-screen-reader' : ''}", + class: class_names("txt-nowrap txt-uppercase", "for-screen-reader": icon_only), id: involvement_label_id ) ])